public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Robert Luberda <robert@debian•org>
To: Eric Wong <normalperson@yhbt•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id
Date: Sun, 19 Aug 2012 23:46:57 +0200	[thread overview]
Message-ID: <50315ED1.6080803@debian.org> (raw)
In-Reply-To: <20120801230118.GA15479@dcvr.yhbt.net>

Eric Wong wrote:

Hi,
>> I don't think it will be hard to make it configurable. I can try to make
>> such a change, do you have any preferences about the option and
>> configuration key names?
> 
> No preference off the top of my head.  As long as it makes sense to
> enough people here and is consistent in style with existing options in
> git.

I have been quite a busy recently, so it took me longer that I thought.

It was quite hard for me to think some sensible option name, and finally
have chosen --trim-svn-log (svn.trimsvnlog as config key name). Please
let me know if such name is ok for you. If not, I'll try to find a
different one (but as I wrote I'm not really good at giving names to
options/functions/variables, etc. :()

I considered making the option a default one for new git svn clones, so
that existing repositories would use the older approach, but I gave up
the idea, and implemented the simpler solution, in which the option must
be given explicitly if one needs the new behavior. If making it a
default for new clones would make sense for you, I can try to implement
this as well.

For consistency, the `--add-author-from' option was modified not to add
an extra new line before 'From: ' line when the newly introduced option
is in effect.

I'm sending a new patch in next e-mail, could you please look at it and
share any comments you might have? One thing I was not sure about is the
requirement, introduced in the change, of having a whitespace character
after a colon in pseudo-header lines
(e.g. `From:somebody <somebody@somewhere•com>' won't be considered as a
pseudo-header) - is this consistent with a way git handles
headers/pseudo-headers?

Best regards,
robert

next prev parent reply	other threads:[~2012-08-19 22:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-01 21:23 [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id Robert Luberda
2012-08-01 21:43 ` Eric Wong
2012-08-01 22:27   ` Robert Luberda
2012-08-01 23:01     ` Eric Wong
2012-08-19 21:46       ` Robert Luberda [this message]
2012-08-19 21:52         ` [PATCH/RFC] git svn: optionally trim imported log messages Robert Luberda
2012-08-19 23:59           ` Junio C Hamano
2012-08-24 22:38             ` Robert Luberda
2012-08-24 23:38               ` Junio C Hamano
2012-08-21 21:45         ` [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id Eric Wong
2012-08-21 22:35           ` Junio C Hamano
2012-08-24 23:14             ` Robert Luberda
2012-08-26  0:36               ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50315ED1.6080803@debian.org \
    --to=robert@debian$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=normalperson@yhbt$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox