From: Jonathan Nieder <jrnieder@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Ramsay Jones <ramsay@ramsay1•demon.co.uk>,
Jeff King <peff@peff•net>, GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH] Add the GIT_SENTINEL macro
Date: Thu, 18 Jul 2013 20:36:34 -0700 [thread overview]
Message-ID: <20130719033634.GB27853@google.com> (raw)
In-Reply-To: <7vr4evz0oc.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> It seems to apply well on the tip of jk/gcc-function-attributes.
>
> - This macro is not about "git" at all, so I'll edit the patch to
> call it GCC_ATTR_SENTINEL before applying.
Would naming it something like LAST_ARG_MUST_BE_NULL instead make
sense? That way, if some other compiler gains a different syntax for
the same annotation, it would be possible to do
#if defined(__GNUC__) && __GNUC__ >= 4
# define LAST_ARG_MUST_BE_NULL __attribute__((sentinel))
#elif defined(_MSC_VER) && _MSC_VER > 27
# define LAST_ARG_MUST_BE_NULL __declspec(lastargnull)
#else
# define LAST_ARG_MUST_BE_NULL
#endif
next prev parent reply other threads:[~2013-07-19 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 20:02 [PATCH] Add the GIT_SENTINEL macro Ramsay Jones
2013-07-18 20:31 ` Jeff King
2013-07-18 21:06 ` Jonathan Nieder
2013-07-19 3:30 ` Junio C Hamano
2013-07-19 3:36 ` Jonathan Nieder [this message]
2013-07-19 7:18 ` Junio C Hamano
2013-07-20 19:13 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719033634.GB27853@google.com \
--to=jrnieder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ramsay@ramsay1$(echo .)demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox