From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Junio C Hamano <gitster@pobox•com>
Cc: Jeff King <peff@peff•net>, Jonathan Nieder <jrnieder@gmail•com>,
GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH] Add the GIT_SENTINEL macro
Date: Sat, 20 Jul 2013 20:13:10 +0100 [thread overview]
Message-ID: <51EAE146.2070309@ramsay1.demon.co.uk> (raw)
In-Reply-To: <7vr4evz0oc.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsay1•demon.co.uk> writes:
>
>> The sentinel function attribute is not understood by versions of
>> the gcc compiler prior to v4.0. At present, for earlier versions
>> of gcc, the build issues 108 warnings related to the unknown
>> attribute. In order to suppress the warnings, we conditionally
>> define the GIT_SENTINEL macro to provide the sentinel attribute
>> for gcc v4.0 and newer.
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
>> ---
>>
>> This was built on the next branch
>
> It seems to apply well on the tip of jk/gcc-function-attributes.
>
>
> - This macro is not about "git" at all, so I'll edit the patch to
> call it GCC_ATTR_SENTINEL before applying.
>
> - Also I'll drop the (0) at the end.
>
> Thanks.
Yes, GCC_ATTR_SENTINEL is a better name, but I like LAST_ARG_MUST_BE_NULL
even more! The final commit 9fe3edc4 ("Add the LAST_ARG_MUST_BE_NULL macro",
18-07-2013) is much better than my patch and works beautifully.
Thanks Junio, Jeff and Jonathan!
ATB,
Ramsay Jones
prev parent reply other threads:[~2013-07-21 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 20:02 [PATCH] Add the GIT_SENTINEL macro Ramsay Jones
2013-07-18 20:31 ` Jeff King
2013-07-18 21:06 ` Jonathan Nieder
2013-07-19 3:30 ` Junio C Hamano
2013-07-19 3:36 ` Jonathan Nieder
2013-07-19 7:18 ` Junio C Hamano
2013-07-20 19:13 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EAE146.2070309@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox