From: Jeff King <peff@peff•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: "Kyle J. McKay" <mackyle@gmail•com>,
"Torsten Bögershausen" <tboegi@web•de>,
"Git Mailing List" <git@vger•kernel.org>
Subject: Re: t5539 broken under Mac OS X
Date: Thu, 15 Jan 2015 18:57:53 -0500 [thread overview]
Message-ID: <20150115235752.GB25120@peff.net> (raw)
In-Reply-To: <xmqqa91j6537.fsf@gitster.dls.corp.google.com>
On Thu, Jan 15, 2015 at 02:39:56PM -0800, Junio C Hamano wrote:
> Before writing that patchlet, I briefly looked at grep output and
> thought that many that are protected only by SANITY lacked POSIXPERM
> by mistake:
>
> t/t1004-read-tree-m-u-wf.sh:test_expect_success SANITY 'funny symlink in...
> t/t3600-rm.sh 'Test that "git rm -f" fails if its rm fails'
> t/t7300-clean.sh:test_expect_success SANITY 'removal failure' '
> t/t7300-clean.sh:test_expect_success SANITY 'git clean -d with an...
>
> All of the above relies on a working chmod as far as I can tell, so
> they should require POSIXPERM,SANITY, not just SANITY.
Yeah, skimming the grep output, I had the same feeling. But I did not
investigate closely.
> lib-httpd should, if it cares about the root-ness, be checking that
> in a more direct way, "test_have_prereq RUNNING_AS_ROOT". Making
> the implementation of that portable is another matter, though.
Exactly. I am happy to submit a patch, but I cannot think of any
mechanisms besides:
1. Calling `id`, which I suspect is very not portable.
2. Writing a C program to check getuid(). That's portable for most
Unixes. It looks like we already have a hacky wrapper on mingw that
will always return "1".
Is (2) too gross?
-Peff
next prev parent reply other threads:[~2015-01-15 23:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 15:39 t5539 broken under Mac OS X Torsten Bögershausen
2015-01-14 18:37 ` Junio C Hamano
2015-01-14 19:50 ` Torsten Bögershausen
2015-01-14 21:17 ` Jeff King
2015-01-15 5:48 ` Kyle J. McKay
2015-01-15 20:29 ` Junio C Hamano
2015-01-15 22:27 ` Jeff King
2015-01-15 22:39 ` Junio C Hamano
2015-01-15 23:57 ` Jeff King [this message]
2015-01-16 0:04 ` Junio C Hamano
2015-01-16 1:32 ` [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT Jeff King
2015-01-16 3:27 ` Kyle J. McKay
2015-01-16 3:34 ` Jeff King
2015-01-16 9:16 ` Jeff King
2015-01-16 18:32 ` Junio C Hamano
2015-01-16 19:02 ` Junio C Hamano
2015-01-17 23:35 ` Torsten Bögershausen
2015-01-21 22:33 ` Junio C Hamano
2015-01-22 21:51 ` Torsten Bögershausen
2015-01-22 22:07 ` Junio C Hamano
2015-01-23 6:00 ` Torsten Bögershausen
2015-02-12 22:36 ` Junio C Hamano
2015-02-14 8:36 ` [msysGit] " Torsten Bögershausen
2015-02-15 23:48 ` Junio C Hamano
2015-01-23 21:24 ` [msysGit] " Torsten Bögershausen
2015-01-23 23:02 ` Junio C Hamano
2015-01-24 9:41 ` [msysGit] " Johannes Schindelin
2015-01-16 18:38 ` Kyle J. McKay
2015-01-16 18:38 ` Kyle J. McKay
2015-01-16 20:04 ` Achim Gratz
2015-01-27 1:44 ` t5539 broken under Mac OS X Erik Faye-Lund
2015-01-27 2:51 ` Junio C Hamano
2015-01-27 16:35 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115235752.GB25120@peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mackyle@gmail$(echo .)com \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox