From: Junio C Hamano <gitster@pobox•com>
To: Erik Faye-Lund <kusmabite@gmail•com>
Cc: "Jeff King" <peff@peff•net>, "Kyle J. McKay" <mackyle@gmail•com>,
"Torsten Bögershausen" <tboegi@web•de>,
"Git Mailing List" <git@vger•kernel.org>
Subject: Re: t5539 broken under Mac OS X
Date: Mon, 26 Jan 2015 18:51:53 -0800 [thread overview]
Message-ID: <xmqqh9vdlyuu.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CABPQNSYZMS+feX=jSxwOhr+P8isroct2=Dcw18LSjCYZUvug=A@mail.gmail.com> (Erik Faye-Lund's message of "Tue, 27 Jan 2015 02:44:14 +0100")
Erik Faye-Lund <kusmabite@gmail•com> writes:
> On Fri, Jan 16, 2015 at 1:04 AM, Junio C Hamano <gitster@pobox•com> wrote:
>> Jeff King <peff@peff•net> writes:
>>
>>> Exactly. I am happy to submit a patch, but I cannot think of any
>>> mechanisms besides:
>>>
>>> 1. Calling `id`, which I suspect is very not portable.
>>>
>>> 2. Writing a C program to check getuid(). That's portable for most
>>> Unixes. It looks like we already have a hacky wrapper on mingw that
>>> will always return "1".
>>>
>>> Is (2) too gross?
>>
>> Not overly gross compared to some existing test-*.c files, I would
>> say.
>>
>> I wondered what 'perl -e 'print $>' would say in mingw, and if that
>> is portable enough, though.
>
> $ perl -e 'print $>'
> 500
Thanks for a follow-up.
Is "id -u" not useful over there? I ask because that is what is
used in the version tentatively queued on 'pu' for NOT_ROOT
prerequisite (the jk/sanity topic).
The SANITY prerequisite in that topic needs to be replaced with the
one from Torsten that attempts to check what we want to know in a
more direct way; i.e. "after making a directory or a file read-only,
does the filesystem really honours that, or lets us clobber?" is
what we need to know to skip some tests, and we should check that,
instead of "is / writable by us?" or "are we root?".
next prev parent reply other threads:[~2015-01-27 2:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 15:39 t5539 broken under Mac OS X Torsten Bögershausen
2015-01-14 18:37 ` Junio C Hamano
2015-01-14 19:50 ` Torsten Bögershausen
2015-01-14 21:17 ` Jeff King
2015-01-15 5:48 ` Kyle J. McKay
2015-01-15 20:29 ` Junio C Hamano
2015-01-15 22:27 ` Jeff King
2015-01-15 22:39 ` Junio C Hamano
2015-01-15 23:57 ` Jeff King
2015-01-16 0:04 ` Junio C Hamano
2015-01-16 1:32 ` [PATCH] t/lib-httpd: switch SANITY check for NOT_ROOT Jeff King
2015-01-16 3:27 ` Kyle J. McKay
2015-01-16 3:34 ` Jeff King
2015-01-16 9:16 ` Jeff King
2015-01-16 18:32 ` Junio C Hamano
2015-01-16 19:02 ` Junio C Hamano
2015-01-17 23:35 ` Torsten Bögershausen
2015-01-21 22:33 ` Junio C Hamano
2015-01-22 21:51 ` Torsten Bögershausen
2015-01-22 22:07 ` Junio C Hamano
2015-01-23 6:00 ` Torsten Bögershausen
2015-02-12 22:36 ` Junio C Hamano
2015-02-14 8:36 ` [msysGit] " Torsten Bögershausen
2015-02-15 23:48 ` Junio C Hamano
2015-01-23 21:24 ` [msysGit] " Torsten Bögershausen
2015-01-23 23:02 ` Junio C Hamano
2015-01-24 9:41 ` [msysGit] " Johannes Schindelin
2015-01-16 18:38 ` Kyle J. McKay
2015-01-16 18:38 ` Kyle J. McKay
2015-01-16 20:04 ` Achim Gratz
2015-01-27 1:44 ` t5539 broken under Mac OS X Erik Faye-Lund
2015-01-27 2:51 ` Junio C Hamano [this message]
2015-01-27 16:35 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh9vdlyuu.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kusmabite@gmail$(echo .)com \
--cc=mackyle@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox