From: Jeff King <peff@peff•net>
To: Michael J Gruber <git@drmicha•warpmail.net>
Cc: git@vger•kernel.org
Subject: Re: [WIP/RFH/PATCH 3/3] t/lib-git-svn: adjust config to apache 2.4
Date: Fri, 10 Apr 2015 05:23:17 +0200 [thread overview]
Message-ID: <20150410032317.GB11280@peff.net> (raw)
In-Reply-To: <0631c09d394dedb803a100e81ce4052a57b4e73e.1428505184.git.git@drmicha.warpmail.net>
On Wed, Apr 08, 2015 at 05:05:26PM +0200, Michael J Gruber wrote:
> The current config is tailored to apache 2.2. Apache 2.4 fails to start
> with it.
>
> Adjust the config to apache 2.4.
I think this needs more conditional config. See the similar fixes I did
in:
296f0b3 (t/lib-httpd/apache.conf: configure an MPM module for apache
2.4, 2013-06-09)
and:
0442743 (t/lib-httpd/apache.conf: do not use LockFile in apache >=
2.4, 2013-06-09)
And also beware of the ordering problem fixed by:
5bdc47e (lib-httpd/apache.conf: check version only after mod_version
loads, 2013-06-21)
Curiously, though, the git-svn tests seem to run fine for me on Apache
2.4 without your patch. I wonder if the fixes I mentioned above (which I
definitely needed to get the regular http tests running on Debian back
then) are not necessary on my system anymore (e.g., because the apache2
package now ships with better-compatible config).
> Again, I'm wondering who is running these tests at all, but also:
I run the http tests regularly (and have for a long time). I don't
usually run the svn tests, though.
> Why do we leverage lib-httpd so little from lib-git-svn?
I don't mind us doing the minimal work here to bring the svn tests to a
working state for your platform. As Eric mentions, refactoring test
infrastructure is boring and thankless work. :)
But an alternate solution for patches 2 and 3 might be to share more of
the startup code and config between the two. I don't know how painful
that would be. From a cursory look, I think t/lib-httpd/apache.conf
would have to get split into two parts: one to get apache running at
all, and one to setup the <Location> and other bits related directly to
the http tests.
-Peff
next prev parent reply other threads:[~2015-04-10 3:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 15:05 [PATCH 0/3] Make httpd tests run Michael J Gruber
2015-04-08 15:05 ` [PATCH 1/3] t/lib-httpd: load mod_unixd Michael J Gruber
[not found] ` <5525A208.6060807@web.de>
2015-04-09 9:27 ` Michael J Gruber
2015-04-10 3:09 ` Jeff King
2015-04-08 15:05 ` [PATCH 2/3] t/lib-git-svn: check same httpd module dirs as lib-httpd Michael J Gruber
2015-04-08 15:05 ` [WIP/RFH/PATCH 3/3] t/lib-git-svn: adjust config to apache 2.4 Michael J Gruber
2015-04-08 20:26 ` Eric Wong
2015-04-09 9:33 ` Michael J Gruber
2015-04-09 19:11 ` Eric Wong
2015-04-10 3:23 ` Jeff King [this message]
2015-04-10 3:39 ` Jeff King
2015-04-13 10:14 ` Michael J Gruber
2015-04-09 13:04 ` [PATCH 0/3] Make httpd tests run Kyle J. McKay
2015-04-09 13:14 ` Kyle J. McKay
2015-05-11 11:54 ` [PATCHv2 0/4] Make httpd tests run v2 Michael J Gruber
2015-05-11 11:54 ` [PATCHv2 1/4] t/lib-httpd: load mod_unixd Michael J Gruber
2015-05-11 11:54 ` [PATCHv2 2/4] t/lib-git-svn: check same httpd module dirs as lib-httpd Michael J Gruber
2015-05-11 11:54 ` [PATCH 3/4] t/t91*: do not say how to avoid the tests Michael J Gruber
2015-05-11 11:54 ` [PATCHv2 4/4 (was 3/3, still WIP)] t/lib-git-svn: adjust config to apache 2.4 WIP Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410032317.GB11280@peff.net \
--to=peff@peff$(echo .)net \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox