From: Jeff King <peff@peff•net>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: "Junio C Hamano" <gitster@pobox•com>,
"David Rodríguez" <deivid.rodriguez@gmail•com>,
"Matthew Rothenberg" <mroth@khanacademy•org>,
git@vger•kernel.org
Subject: Re: [PATCH] stop putting argv[0] dirname at front of PATH
Date: Wed, 22 Apr 2015 16:00:19 -0400 [thread overview]
Message-ID: <20150422200019.GE27656@peff.net> (raw)
In-Reply-To: <20150422192317.GI5467@google.com>
On Wed, Apr 22, 2015 at 12:23:17PM -0700, Jonathan Nieder wrote:
> > And
> > not just for finding binaries; we want to find $(sharedir),
> > etc, the same way. The RUNTIME_PREFIX build knob does this
> > the right way
>
> Makes sense. For the reason you say (templatedir, etc) I am surprised
> to hear that that was the motivation, but I can't find any other.
The Makefile was much less mature, then, so I wondered if maybe those
things came later (certainly the munging of $PATH that introduced the
problems came later, as at the time we had a special "we are exec-ing a
git command" custom version of execvp).
But no, the template directory did indeed exist then. I think it was
always a half-baked idea (and got much worse when we stopped putting
git-foo into $bindir).
The relevant thread (which I think I linked the other day) is:
http://article.gmane.org/gmane.comp.version-control.git/16798
-Peff
prev parent reply other threads:[~2015-04-22 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 16:04 PATH modifications for git-hook processes Matthew Rothenberg
2015-04-14 17:17 ` Junio C Hamano
2015-04-15 15:00 ` Matthew Rothenberg
2015-04-16 6:17 ` Jeff King
2015-04-16 6:31 ` Jeff King
2015-04-22 0:39 ` David Rodríguez
2015-04-22 17:46 ` Junio C Hamano
2015-04-22 18:14 ` [PATCH] stop putting argv[0] dirname at front of PATH Jeff King
2015-04-22 18:23 ` Eric Sunshine
2015-04-22 18:36 ` Jeff King
2015-04-22 19:23 ` Jonathan Nieder
2015-04-22 20:00 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422200019.GE27656@peff.net \
--to=peff@peff$(echo .)net \
--cc=deivid.rodriguez@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=mroth@khanacademy$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox