From: Eloy Espinaco <eloyesp@gmail•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Eloy Espinaco <eloyesp@gmail•com>, git@vger•kernel.org
Subject: Re: Verbose as default for commit (optional)
Date: Fri, 24 Apr 2015 20:51:03 -0300 [thread overview]
Message-ID: <20150424235103.GA1798@localhost> (raw)
In-Reply-To: <vpqbnidmgzh.fsf@anie.imag.fr>
Ok, now I found [this
thread](http://thread.gmane.org/gmane.comp.version-control.git/251376)
that seems abandoned, but implements this config, a --no-verbose that
disable it for one-time and the tests, but was not merged (don't know
why)
This was the patch I've intended to attach:
----------------->8--------------------
Subject: [PATCH] Add commit.verbose config to set default.
---
builtin/commit.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/builtin/commit.c b/builtin/commit.c
index da79ac4..ad588ff 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1506,6 +1506,10 @@ static int git_commit_config(const char *k, const char *v, void *cb)
sign_commit = git_config_bool(k, v) ? "" : NULL;
return 0;
}
+ if (!strcmp(k, "commit.verbose")) {
+ verbose = git_config_bool(k, v);
+ return 0;
+ }
status = git_gpg_config(k, v, NULL);
if (status)
--
2.1.4
En Fri, Apr 24, 2015 at 10:03:14PM +0200, Matthieu Moy escribió:
> Eloy Espinaco <eloyesp@gmail•com> writes:
>
> > Hi,
> >
> > It is my first mail to the list, so "hello world".
>
> Hi, and welcome to the list.
>
> > I wanted to make a feature-request about a config setting to make the
> > commit always verbose. I'm not the only one asking for that, there is an
> > old question in [Stack Overflow][1].
>
> This seems a reasonable addition. In general, we commonly have config
> options for commonly used CLI options.
>
> > So I was thinking if it was possible to make a pull request for that, so
> > I attach the patch. (I'm proud of it :) ).
>
> Nice try, but the attached file is empty ;-). Actually, as much as
> possible, avoid sending attachments but prefer inline patches.
>
> You'll need a bit of reading to send a proper patch:
>
> https://github.com/git/git/blob/master/Documentation/SubmittingPatches
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/
--- Eloy Espinaco
next prev parent reply other threads:[~2015-04-25 0:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 19:18 Verbose as default for commit (optional) Eloy Espinaco
2015-04-24 20:03 ` Matthieu Moy
2015-04-24 23:51 ` Eloy Espinaco [this message]
2015-04-25 1:08 ` Eric Sunshine
2015-04-25 4:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424235103.GA1798@localhost \
--to=eloyesp@gmail$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox