public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Eloy Espinaco <eloyesp@gmail•com>,
	Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
	Git List <git@vger•kernel.org>
Subject: Re: Verbose as default for commit (optional)
Date: Fri, 24 Apr 2015 21:33:10 -0700	[thread overview]
Message-ID: <xmqqr3r825fd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cRegJ9b0NyvkrZvJMw3CAU0TdgyzH1DMDjB_hV2X4ysHg@mail.gmail.com> (Eric Sunshine's message of "Fri, 24 Apr 2015 21:08:56 -0400")

Eric Sunshine <sunshine@sunshineco•com> writes:

> On Fri, Apr 24, 2015 at 7:51 PM, Eloy Espinaco <eloyesp@gmail•com> wrote:
>> Ok, now I found [this
>> thread](http://thread.gmane.org/gmane.comp.version-control.git/251376)
>> that seems abandoned, but implements this config, a --no-verbose that
>> disable it for one-time and the tests, but was not merged (don't know
>> why)
>
> I recall reviewing Caleb's patch series and making a number of
> suggestions for improvement. v6 was the last version he posted[1], and
> it seems that he intended to post v7 but never got around to it.
> Apparently, Torstein Hegge asked in February 2015 about picking up
> where Caleb left off, but nothing has materialized.
>
> You are welcome to revive the series by taking reviewer comments into
> account and submitting v7 (and beyond if necessary). Be sure to keep
> Caleb's authorship and sign-off intact, and add your own sign-off
> following his. If you make changes to his patches, briefly describe
> your changes in a bracketed comment in the commit message, starting
> with your initials, like this: [ee: changed blah to bleh].
>
> [1]: http://thread.gmane.org/gmane.comp.version-control.git/251943/focus=264608

Also, the world order has changed recently, if I am not mistaken.
Back when Caleb's series was done, there were only two choices
(i.e. are we verbose, or not verbose?)  Now "commit" and "status"
can take three choices, so commit.verbose boolean would not cut it.

Should the configuration variable be commit.verbose and only affect
"commit" and not "status", or should both of these commands pay
attention to the single variable and behave the same way?

I offhand do not have a strong opinion on these questions, but
whoever is doing a proposal must think about it and justify the
decision.

Thanks.

     prev parent reply	other threads:[~2015-04-25  4:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 19:18 Verbose as default for commit (optional) Eloy Espinaco
2015-04-24 20:03 ` Matthieu Moy
2015-04-24 23:51   ` Eloy Espinaco
2015-04-25  1:08     ` Eric Sunshine
2015-04-25  4:33       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr3r825fd.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
    --cc=eloyesp@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=sunshine@sunshineco$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox