From: Jeff King <peff@peff•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: evgeny <illumsoft.org@gmail•com>, git@vger•kernel.org
Subject: Re: t0005-signals.sh fails with ksh
Date: Fri, 8 May 2015 17:21:47 -0400 [thread overview]
Message-ID: <20150508212146.GA16614@peff.net> (raw)
In-Reply-To: <xmqqwq0iixcs.fsf@gitster.dls.corp.google.com>
On Fri, May 08, 2015 at 02:16:19PM -0700, Junio C Hamano wrote:
> Yeah, ksh has gone too far and now is on the other side, I would
> have to say. Introducing new keywords and semantics to let its
> users use new features (e.g. "let") is one thing, but breaking a
> valid POSIX shell construct and interpreting it in an incompatible
> way is going just too far for it to be treated as a Bourne variant.
Yeah, especially after my followup email, I think I'm not on the fence
anymore.
> I wonder if zsh is in the same league. Do we support people who do
> SHELL_PATH=/bin/zsh and bend over backwards when it breaks?
I tried "make SHELL_PATH=zsh test", but had trouble seeing the test
output for all of the errors being spewed to stderr. ;)
Certainly this:
$ zsh ./t0000-basic.sh -v -i
> [...]
test_cmp:1: command not found: diff -u
not ok 4 - pretend we have a fully passing test suite
is not especially encouraging (it looks like running "$FOO bar" does not
word-split $FOO). I am not a zsh user, though, so there may be ways to
convince it to be more POSIX-y (e.g., just calling it as "sh").
-Peff
next prev parent reply other threads:[~2015-05-08 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 20:15 t0005-signals.sh fails with ksh evgeny
2015-05-08 20:34 ` Junio C Hamano
2015-05-08 20:55 ` Jeff King
2015-05-08 21:14 ` Jeff King
2015-05-08 21:39 ` Junio C Hamano
2015-05-08 23:43 ` evgeny
2015-05-09 8:20 ` Andreas Schwab
2015-05-08 21:16 ` Junio C Hamano
2015-05-08 21:21 ` Jeff King [this message]
2015-05-09 20:01 ` brian m. carlson
2015-05-08 23:05 ` evgeny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508212146.GA16614@peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=illumsoft.org@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox