From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: evgeny <illumsoft.org@gmail•com>, git@vger•kernel.org
Subject: Re: t0005-signals.sh fails with ksh
Date: Fri, 08 May 2015 14:16:19 -0700 [thread overview]
Message-ID: <xmqqwq0iixcs.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150508205548.GB13457@peff.net> (Jeff King's message of "Fri, 8 May 2015 16:55:48 -0400")
Jeff King <peff@peff•net> writes:
> On Fri, May 08, 2015 at 01:34:49PM -0700, Junio C Hamano wrote:
>
>> evgeny <illumsoft.org@gmail•com> writes:
>>
>> > expecting success:
>> > OUT=$( ((large_git; echo $? 1>&3) | :) 3>&1 ) &&
>> > test "$OUT" -eq 141
>> >
>> > t0005-signals.sh[499]: eval: syntax error at line 4: `(' unmatched
>> > Memory fault
>>
>> Does this work if you did
>>
>> OUT=$( ( (large_git ; echo $? 1>&3) | : ) 3>&2 ) &&
>>
>> instead?
>
> It does for me. I've tested our suite with mksh before, and it passed
> (that's why the earlier check already covers ksh). But using the ksh I
> get from "apt-get install ksh" on Debian (ksh93, it looks like?) fails
> as described.
> ...
Yuck.
> I'm on the fence, though, on declaring ksh93 to be unsupported. I don't
> know how many other instances of this are in our test suite, and it's
> one more maintenance headache to deal with. Are there really platforms
> with no actual POSIX shell (on Solaris, for example, the xpg6 shell is a
> much better choice)?
Yeah, ksh has gone too far and now is on the other side, I would
have to say. Introducing new keywords and semantics to let its
users use new features (e.g. "let") is one thing, but breaking a
valid POSIX shell construct and interpreting it in an incompatible
way is going just too far for it to be treated as a Bourne variant.
I wonder if zsh is in the same league. Do we support people who do
SHELL_PATH=/bin/zsh and bend over backwards when it breaks?
I'm on the fence, too.
next prev parent reply other threads:[~2015-05-08 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 20:15 t0005-signals.sh fails with ksh evgeny
2015-05-08 20:34 ` Junio C Hamano
2015-05-08 20:55 ` Jeff King
2015-05-08 21:14 ` Jeff King
2015-05-08 21:39 ` Junio C Hamano
2015-05-08 23:43 ` evgeny
2015-05-09 8:20 ` Andreas Schwab
2015-05-08 21:16 ` Junio C Hamano [this message]
2015-05-08 21:21 ` Jeff King
2015-05-09 20:01 ` brian m. carlson
2015-05-08 23:05 ` evgeny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwq0iixcs.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=illumsoft.org@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox