From: Dan Aloni <alonid@gmail•com>
To: Jeff King <peff@peff•net>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH v6 3/3] ident: cleanup wrt ident's source
Date: Fri, 5 Feb 2016 23:03:30 +0200 [thread overview]
Message-ID: <20160205210330.GA7245@gmail.com> (raw)
In-Reply-To: <20160205192413.GB7245@sigill.intra.peff.net>
On Fri, Feb 05, 2016 at 02:24:13PM -0500, Jeff King wrote:
> On Fri, Feb 05, 2016 at 11:05:19AM -0800, Junio C Hamano wrote:
>
> > Dan Aloni <alonid@gmail•com> writes:
> >
> > > This change condenses the variables that tells where we got the user's
> > > ident into single enum, instead of a collection of booleans.
> > >
> > > In addtion, also have {committer,author}_ident_sufficiently_given
> > > directly probe the environment and the afformentioned enum instead of
> > > relying on git_{committer,author}_info to do so.
> > >
> > > Signed-off-by: Dan Aloni <alonid@gmail•com>
> > > Helped-by: Jeff King <peff@peff•net>
> > > Helped-by: Junio C Hamano <gitster@pobox•com>
> > > ---
> > > ident.c | 126 ++++++++++++++++++++++++++++++++++++++++------------------------
> > > 1 file changed, 80 insertions(+), 46 deletions(-)
> >
> > Peff what do you think? I am asking you because personally I do not
> > find this particularly easier to read than the original, but since
> > you stared at the code around here recently much longer than I did
> > when doing the 1/3, I thought you may be a better judge than I am.
>
> I'm not sure it is really worth it unless we are going to expose this to
> the user, and let them say "I am OK with IDENT_SOURCE_GUESSED, but not
> IDENT_SOURCE_GUESSED_BOGUS" or similar.
>
> Without that, I think it is probably just making things a bit more
> brittle.
Okay, will drop it now.
--
Dan Aloni
prev parent reply other threads:[~2016-02-05 21:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 7:42 [PATCH v6] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed Dan Aloni
2016-02-05 7:42 ` [PATCH v6 1/3] fmt_ident: refactor strictness checks Dan Aloni
2016-02-05 7:42 ` [PATCH v6 2/3] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed Dan Aloni
2016-02-05 19:18 ` Jeff King
2016-02-05 19:30 ` Eric Sunshine
2016-02-05 19:31 ` Junio C Hamano
2016-02-05 21:14 ` Dan Aloni
2016-02-05 7:42 ` [PATCH v6 3/3] ident: cleanup wrt ident's source Dan Aloni
2016-02-05 19:05 ` Junio C Hamano
2016-02-05 19:24 ` Jeff King
2016-02-05 21:03 ` Dan Aloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205210330.GA7245@gmail.com \
--to=alonid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox