From: Dan Aloni <alonid@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org, Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCH v6 2/3] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed
Date: Fri, 5 Feb 2016 23:14:35 +0200 [thread overview]
Message-ID: <20160205211435.GB7245@gmail.com> (raw)
In-Reply-To: <xmqqio23c5t5.fsf@gitster.mtv.corp.google.com>
On Fri, Feb 05, 2016 at 11:31:34AM -0800, Junio C Hamano wrote:
> > + If you have multiple email addresses that you would like to set
> > + up per repository, you may want to set this to 'true' in the global
> > + config, and then Git would prompt you to set user.email separately,
> > + in each of the cloned repositories.
>
> The first sentence mentioned both name and email, but here the
> example is only about email. A first time reader might be led into
> thinking this is only about email and not name, but I am assuming
> that is not the intention (i.e. this is merely showing just one use
> case).
>[..]
Going to revise per yours and Jeff's suggestions.
>[..]
> I can read the split expression either with && hanging at the end of
> line or && leading the next line just fine, but you'd want to be
> consistent especially when you are writing two almost identical
> things.
Sure.
>[..]
> test_expect_success 'suceed with config' '
> test_when_finished reprepare &&
> test_config user.email test@ok•com &&
> test_must_fail git commit -m msg
> '
>
> Note that you do not need "test_unconfig user.email" in reprepare,
> as the variable is set in one test with test_config, which uses
> test_when_finished to arrange the variable to be removed after
> running the test.
Alright. It was worth to understand the differing behavior between
'test_config' and 'git config'.
--
Dan Aloni
next prev parent reply other threads:[~2016-02-05 21:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 7:42 [PATCH v6] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed Dan Aloni
2016-02-05 7:42 ` [PATCH v6 1/3] fmt_ident: refactor strictness checks Dan Aloni
2016-02-05 7:42 ` [PATCH v6 2/3] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed Dan Aloni
2016-02-05 19:18 ` Jeff King
2016-02-05 19:30 ` Eric Sunshine
2016-02-05 19:31 ` Junio C Hamano
2016-02-05 21:14 ` Dan Aloni [this message]
2016-02-05 7:42 ` [PATCH v6 3/3] ident: cleanup wrt ident's source Dan Aloni
2016-02-05 19:05 ` Junio C Hamano
2016-02-05 19:24 ` Jeff King
2016-02-05 21:03 ` Dan Aloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205211435.GB7245@gmail.com \
--to=alonid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox