From: Johan Hovold <johan@kernel•org>
To: git@vger•kernel.org
Cc: Jeff King <peff@peff•net>,
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
Kevin Daudt <me@ikke•info>, Junio C Hamano <gitster@pobox•com>,
Larry Finger <Larry.Finger@lwfinger•net>
Subject: body-CC-comment regression
Date: Thu, 16 Feb 2017 18:49:24 +0100 [thread overview]
Message-ID: <20170216174924.GB2625@localhost> (raw)
Hi,
I recently noticed that after an upgrade, git-send-email (2.10.2)
started aborting when trying to send patches that had a linux-kernel
stable-tag in its body. For example,
Cc: <stable@vger•kernel.org> # 4.4
was now parsed as
"stable@vger•kernel.org#4.4"
which resulted in
Died at /usr/libexec/git-core/git-send-email line 1332, <FIN> line 1.
This tends to happen in the middle of a series after the cover letter
had been sent just to make things worse...
I finally got around to looking into this today and discovered this
thread ("Re: Formatting problem send_mail in version 2.10.0"):
https://marc.info/?l=git&m=147633706724793&w=2
The problem with the resulting fixes that are now in 2.11.1 is that
git-send-email no longer discards the trailing comment but rather
shoves it into the name after adding some random white space:
"# 3 . 3 . x : 1b9508f : sched : Rate-limit newidle" <stable@vger•kernel.org>"
This example is based on the example from
Documentation/process/stable-kernel-rules.rst:
Cc: <stable@vger•kernel.org> # 3.3.x: 1b9508f: sched: Rate-limit newidle
and this format for stable-tags has been documented at least since 2009
and 8e9b9362266d ("Doc/stable rules: add new cherry-pick logic"), and
has been supported by git since 2012 and 831a488b76e0 ("git-send-email:
remove garbage after email address") I believe.
Can we please revert to the old behaviour of simply discarding such
comments (from body-CC:s) or at least make it configurable through a
configuration option?
Thanks,
Johan
next reply other threads:[~2017-02-16 17:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 17:49 Johan Hovold [this message]
2017-02-16 17:59 ` body-CC-comment regression Junio C Hamano
2017-02-16 18:14 ` Johan Hovold
2017-02-16 18:16 ` Matthieu Moy
2017-02-17 11:06 ` Johan Hovold
2017-02-17 13:16 ` Matthieu Moy
2017-02-17 16:42 ` Johan Hovold
2017-02-17 16:58 ` Matthieu Moy
2017-02-17 17:30 ` Johan Hovold
2017-02-17 18:18 ` Junio C Hamano
2017-02-17 18:23 ` Johan Hovold
2017-02-17 18:28 ` Junio C Hamano
2017-02-17 18:44 ` Matthieu Moy
2017-02-17 20:05 ` Junio C Hamano
2017-02-17 20:20 ` Matthieu Moy
2017-02-17 22:22 ` Junio C Hamano
2017-02-17 23:04 ` Junio C Hamano
2017-02-20 11:44 ` [PATCH v2] send-email: only allow one address per body tag Johan Hovold
2017-02-20 12:10 ` Matthieu Moy
2017-02-23 18:53 ` Junio C Hamano
2017-02-26 20:45 ` Matthieu Moy
2017-02-17 17:38 ` body-CC-comment regression Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216174924.GB2625@localhost \
--to=johan@kernel$(echo .)org \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=me@ikke$(echo .)info \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox