public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ramsay Jones <ramsay@ramsayjones•plus.com>
To: git@vger•kernel.org
Cc: Patrick Steinhardt <ps@pks•im>,
	irecca.kun@gmail•com, Junio C Hamano <gitster@pobox•com>,
	Ramsay Jones <ramsay@ramsayjones•plus.com>
Subject: [PATCH 0/2] meson regression fix
Date: Wed, 16 Jul 2025 00:32:37 +0100	[thread overview]
Message-ID: <20250715233239.1539780-1-ramsay@ramsayjones.plus.com> (raw)
In-Reply-To: <f614e1c8-91a9-4430-9d60-5aca05170b4a@ramsayjones.plus.com>

As promised, here is the patch to fix the regression caused by
commit 837f637cf5 ("meson.build: correct setting of GIT_EXEC_PATH",
2025-05-19).

I compared the meson and corresponding make installations, which
shows (in addition to fixing the regression):

  - the make install includes 'gitk' and 'git-gui' which is
    missing from the meson install.

  - the make install includes all of the 'builtin' commands
    in the 'library executables' (e.g. git-add), which the
    meson install omits. (I thought we had stopped 'installing'
    the builtins).

  - the make install uses hard links whereas meson uses symbolic
    links.

  - meson omits the Irish translation (see patch #2).

I noticed some other problems, which I was chasing to see if I could
fix them here, but it was taking me down an unexpectedly deep rabit
hole, so ...

ATB,
Ramsay Jones


Ramsay Jones (2):
  meson: fix installation when -Dlibexexdir is set
  po/meson.build: add missing 'ga' language code

 meson.build    | 42 +++++++++++++++++++++---------------------
 po/meson.build |  1 +
 2 files changed, 22 insertions(+), 21 deletions(-)

-- 
2.50.0


  parent reply	other threads:[~2025-07-15 23:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10  8:03 What's cooking in git.git (Jul 2025, #03; Wed, 9) Junio C Hamano
2025-07-10 19:32 ` [-SPAM-] " Ramsay Jones
2025-07-10 21:12   ` Junio C Hamano
2025-07-10 21:44     ` Ramsay Jones
2025-07-11  8:49       ` Patrick Steinhardt
2025-07-11 15:00         ` Junio C Hamano
2025-07-11 15:39           ` Ramsay Jones
2025-07-15 23:32   ` Ramsay Jones [this message]
2025-07-15 23:32     ` [PATCH 1/2] meson: fix installation when -Dlibexexdir is set Ramsay Jones
2025-07-15 23:32     ` [PATCH 2/2] po/meson.build: add missing 'ga' language code Ramsay Jones
2025-07-11  0:07 ` "What's cooking" incremental update report Junio C Hamano
2025-07-11  2:05 ` What's cooking in git.git (Jul 2025, #03; Wed, 9) Ayush Chandekar
2025-07-11 16:01   ` Junio C Hamano
2025-07-11 18:15     ` Ayush Chandekar
2025-07-11 18:34       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250715233239.1539780-1-ramsay@ramsayjones.plus.com \
    --to=ramsay@ramsayjones$(echo .)plus.com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=irecca.kun@gmail$(echo .)com \
    --cc=ps@pks$(echo .)im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox