* [PATCH] git-gui: simplify PATH de-duplication
@ 2025-08-20 15:31 Mark Levedahl
2025-08-21 18:39 ` Johannes Sixt
0 siblings, 1 reply; 2+ messages in thread
From: Mark Levedahl @ 2025-08-20 15:31 UTC (permalink / raw)
To: git; +Cc: j6t, Mark Levedahl
git-gui since 8fe7861c51 ("git-gui: assure PATH has only absolute
elements.", 2025-04-11) uses a list to maintain order and a dict to
detect duplicated elements without quadratic complexity. But, Tcl's
dict explicitly maintains keys in the order first added, thus the list
is not needed. Simplify the code.
Signed-off-by: Mark Levedahl <mlevedahl@gmail•com>
---
git-gui.sh | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index b64d065..4528b22 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -103,21 +103,16 @@ if {[is_Windows]} {
set _path_sep {:}
}
-set _search_path {}
set _path_seen [dict create]
foreach p [split $env(PATH) $_path_sep] {
# Keep only absolute paths, getting rid of ., empty, etc.
if {[file pathtype $p] ne {absolute}} {
continue
}
- # Keep only the first occurence of any duplicates.
set norm_p [file normalize $p]
- if {[dict exists $_path_seen $norm_p]} {
- continue
- }
dict set _path_seen $norm_p 1
- lappend _search_path $norm_p
}
+set _search_path [dict keys $_path_seen]
unset _path_seen
set env(PATH) [join $_search_path $_path_sep]
--
2.51.0.99.15
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] git-gui: simplify PATH de-duplication
2025-08-20 15:31 [PATCH] git-gui: simplify PATH de-duplication Mark Levedahl
@ 2025-08-21 18:39 ` Johannes Sixt
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Sixt @ 2025-08-21 18:39 UTC (permalink / raw)
To: Mark Levedahl, git
Am 20.08.25 um 17:31 schrieb Mark Levedahl:
> git-gui since 8fe7861c51 ("git-gui: assure PATH has only absolute
> elements.", 2025-04-11) uses a list to maintain order and a dict to
> detect duplicated elements without quadratic complexity. But, Tcl's
> dict explicitly maintains keys in the order first added, thus the list
> is not needed. Simplify the code.
>
> Signed-off-by: Mark Levedahl <mlevedahl@gmail•com>
> ---
> git-gui.sh | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/git-gui.sh b/git-gui.sh
> index b64d065..4528b22 100755
> --- a/git-gui.sh
> +++ b/git-gui.sh
> @@ -103,21 +103,16 @@ if {[is_Windows]} {
> set _path_sep {:}
> }
>
> -set _search_path {}
> set _path_seen [dict create]
> foreach p [split $env(PATH) $_path_sep] {
> # Keep only absolute paths, getting rid of ., empty, etc.
> if {[file pathtype $p] ne {absolute}} {
> continue
> }
> - # Keep only the first occurence of any duplicates.
> set norm_p [file normalize $p]
> - if {[dict exists $_path_seen $norm_p]} {
> - continue
> - }
> dict set _path_seen $norm_p 1
> - lappend _search_path $norm_p
> }
> +set _search_path [dict keys $_path_seen]
> unset _path_seen
>
> set env(PATH) [join $_search_path $_path_sep]
Thanks, this looks good; queued. I tweaked it to keep the comment.
-- Hannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-21 18:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-20 15:31 [PATCH] git-gui: simplify PATH de-duplication Mark Levedahl
2025-08-21 18:39 ` Johannes Sixt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox