public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jeff King <peff@peff•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: Sruteesh Kumar <sruteesh.oss@protonmail•com>,
	"git@vger•kernel.org" <git@vger•kernel.org>
Subject: [PATCH v2 0/2] fix "foo**/bar" matching "foobar"
Date: Sun, 26 Oct 2025 11:40:36 -0400	[thread overview]
Message-ID: <20251026154036.GA2173430@coredump.intra.peff.net> (raw)
In-Reply-To: <20251026152614.GB2095501@coredump.intra.peff.net>

On Sun, Oct 26, 2025 at 11:26:14AM -0400, Jeff King wrote:

> Me too. I wrote it a few different ways before ending up with the "==
> 1", just because it made the diff smaller. But let me do it as two
> steps, which I think will make it all more clear.

Here it is. Maybe excessive to split it up, but each patch is quite nice
to read now. :)

  [1/2]: match_pathname(): reorder prefix-match check
  [2/2]: match_pathname(): give fnmatch one char of prefix context

 dir.c              | 18 ++++++++++++------
 t/t0008-ignores.sh | 11 +++++++++++
 2 files changed, 23 insertions(+), 6 deletions(-)

-Peff

  reply	other threads:[~2025-10-26 15:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-10 14:57 Probable issue with code/documentation Sruteesh Kumar
2025-10-14  0:34 ` [PATCH] match_pathname(): give fnmatch one char of prefix context Jeff King
2025-10-14  3:09   ` Jeff King
2025-10-22 16:19   ` Sruteesh Kumar
2025-10-23 20:28   ` Junio C Hamano
2025-10-24 18:28     ` Sruteesh Kumar
2025-10-26 15:18     ` Jeff King
2025-10-26 15:26     ` Jeff King
2025-10-26 15:40       ` Jeff King [this message]
2025-10-26 15:41         ` [PATCH v2 1/2] match_pathname(): reorder prefix-match check Jeff King
2025-10-26 15:42         ` [PATCH v2 2/2] match_pathname(): give fnmatch one char of prefix context Jeff King
2025-10-26 23:29       ` [PATCH] " Junio C Hamano
2025-10-27 14:29         ` Jeff King
2025-10-27 15:35           ` Junio C Hamano
2025-10-28 23:19             ` Jeff King
2025-10-29 15:32               ` [PATCH] doc: document backslash in gitignore patterns Jeff King
2025-10-29 15:55                 ` Jeff King
2025-10-30 13:40                   ` D. Ben Knoble
2025-10-30 15:08                     ` Jeff King
2025-10-30 16:05                       ` Ben Knoble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251026154036.GA2173430@coredump.intra.peff.net \
    --to=peff@peff$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=sruteesh.oss@protonmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox