From: Brian Lyles <brianmlyles@gmail•com>
To: git@vger•kernel.org
Cc: Brian Lyles <brianmlyles@gmail•com>,
adam@dinwoodie•org, hvoigt@hvoigt•net
Subject: [PATCH] t/t1517: indicate that `gui--askyesno` fails with GIT_TEST_INSTALLED
Date: Sun, 30 Nov 2025 21:10:35 -0600 [thread overview]
Message-ID: <20251201031040.1120091-1-brianmlyles@gmail.com> (raw)
Commit e749c87e75 (git-gui: provide question helper for retry fallback
on Windows, 2025-08-28) causes `git-gui--askyesno` to be installed when
running `make install`. This triggers a new occurrence of the issue
noted in commit c4cf8caadd (t/t1517: mark tests that fail with
GIT_TEST_INSTALLED, 2025-08-19), which prevents Git v2.52.0 from
building in nixpkgs [1]. Indicate that this is an expected failure.
[1]: https://github.com/NixOS/nixpkgs/issues/465178#issuecomment-3580790826
Signed-off-by: Brian Lyles <brianmlyles@gmail•com>
---
Note that while this does allow nixpkgs to build v2.52.0, I suspect that
this sort of issue is likely to crop up again in the future. I wonder if
it may be beneficial to make some more fundamental change to this test
to avoid future occurrences. If that is preferred (and something that
someone has time to tackle in the near future), I am happy to allow this
patch to be obviated by such a change.
t/t1517-outside-repo.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh
index c824c1a25c..13540388f9 100755
--- a/t/t1517-outside-repo.sh
+++ b/t/t1517-outside-repo.sh
@@ -115,7 +115,7 @@ do
credential-osxkeychain | cvsexportcommit | cvsimport | cvsserver | \
daemon | \
difftool--helper | filter-branch | fsck-objects | get-tar-commit-id | \
- gui | gui--askpass | \
+ gui | gui--askpass | gui--askyesno | \
http-backend | http-fetch | http-push | init-db | \
merge-octopus | merge-one-file | merge-resolve | mergetool | \
mktag | p4 | p4.py | pickaxe | remote-ftp | remote-ftps | \
--
2.51.2
next reply other threads:[~2025-12-01 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 3:10 Brian Lyles [this message]
2025-12-31 19:09 ` [PATCH] t/t1517: indicate that `gui--askyesno` fails with GIT_TEST_INSTALLED Adam Dinwoodie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201031040.1120091-1-brianmlyles@gmail.com \
--to=brianmlyles@gmail$(echo .)com \
--cc=adam@dinwoodie$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=hvoigt@hvoigt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox