From: Jeff King <peff@peff•net>
To: Matthew John Cheetham <mjcheetham@outlook•com>
Cc: git@vger•kernel.org, Daniel Stenberg <daniel@haxx•se>
Subject: Re: [PATCH 2/3] t5563: add missing end-of-line in HTTP header
Date: Fri, 19 Dec 2025 02:32:32 -0500 [thread overview]
Message-ID: <20251219073232.GA3784564@coredump.intra.peff.net> (raw)
In-Reply-To: <FRWPR03MB110658677899817CC49A50DE7C0A8A@FRWPR03MB11065.eurprd03.prod.outlook.com>
On Thu, Dec 18, 2025 at 01:41:54PM +0000, Matthew John Cheetham wrote:
> On 2025-12-18 12:18, Jeff King wrote:
>
> > In t5563, we test how various oddly-formatted WWW-Authenticate headers
> > are passed through curl to git's credential subsystem (and ultimately
> > out to credential helpers). One test, "access using basic auth with
> > wwwauth header mixed line-endings" does something odd. It does not mix
> > line endings at all (which must be CRLF according to the RFC anyway),
> > but omits the line ending entirely for the final header!
>
> Aha! Yes, the test should be using *all CRLF line endings*, and is
> poorly named. I believe the intent here is to test mixed *continuation
> line* characters.
>
> E.g, when a continuation line starts with a space, or a tab character,
> for the same logical header:
>
> WWW-Authenticate: FooBar param1="value1"\r\n
> \r\n
> \tparam2="value2"\r\n
Ah, great. I'm happy that my guess was right and there was not something
trickier going on (which would have made coming up with a workaround
more difficult!). Thanks for confirming.
-Peff
next prev parent reply other threads:[~2025-12-19 7:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 12:11 [PATCH 0/3] test-suite fixes for upcoming curl 8.18.0 Jeff King
2025-12-18 12:13 ` [PATCH 1/3] t5551: handle trailing slashes in expected cookies output Jeff King
2025-12-18 12:18 ` [PATCH 2/3] t5563: add missing end-of-line in HTTP header Jeff King
2025-12-18 13:41 ` Matthew John Cheetham
2025-12-19 7:32 ` Jeff King [this message]
2025-12-18 12:22 ` [PATCH 3/3] t5563: relax whitespace assumptions for unfolded headers Jeff King
2025-12-18 13:45 ` Matthew John Cheetham
2025-12-18 12:37 ` [PATCH 0/3] test-suite fixes for upcoming curl 8.18.0 Daniel Stenberg
2025-12-18 16:49 ` Daniel Stenberg
2025-12-19 8:04 ` Jeff King
2025-12-19 8:47 ` Daniel Stenberg
2025-12-19 23:23 ` Jeff King
2025-12-20 2:14 ` Junio C Hamano
2025-12-19 7:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219073232.GA3784564@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=daniel@haxx$(echo .)se \
--cc=git@vger$(echo .)kernel.org \
--cc=mjcheetham@outlook$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox