From: Jeff King <peff@peff•net>
To: Daniel Stenberg <daniel@haxx•se>
Cc: Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org,
Matthew John Cheetham <mjcheetham@outlook•com>
Subject: Re: [PATCH 0/3] test-suite fixes for upcoming curl 8.18.0
Date: Fri, 19 Dec 2025 18:23:57 -0500 [thread overview]
Message-ID: <20251219232357.GA3960837@coredump.intra.peff.net> (raw)
In-Reply-To: <0s72r344-865q-2n3q-o9q9-p701087s0n04@unkk.fr>
On Fri, Dec 19, 2025 at 09:47:37AM +0100, Daniel Stenberg wrote:
> On Fri, 19 Dec 2025, Jeff King wrote:
>
> > > [1] = https://github.com/curl/curl/commit/9941e7c95bf26f00fd87888a
> >
> > and it fixes the first of Git's failing tests. But if we swap out the
> > space for a tab like this:
>
> Sorry, that was just sloppy of me to not add a test and proper handling for
> that condition. Allow me to fix that in my end. A leading tab in the folding
> part should be replaced by a space.
Thanks! I ran Git's test suite against a build using your 6c7bc9871f
(http: fix for unfolding line starting with TAB, 2025-12-19) and it
works without the whitespace-relaxing in my third patch.
I also double-checked against the current tip of curl's master, which
includes 3388afd2b6 (http: more unfold fixing, 2025-12-19), and
everything remains fine. Thanks for a prompt fix.
Junio: I think we could just drop the third patch here, if we don't mind
test failures against an unreleased version of curl. It's in debian
unstable now, but presumably they'll move to the released 8.18.0 once
it's out.
-Peff
next prev parent reply other threads:[~2025-12-19 23:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 12:11 [PATCH 0/3] test-suite fixes for upcoming curl 8.18.0 Jeff King
2025-12-18 12:13 ` [PATCH 1/3] t5551: handle trailing slashes in expected cookies output Jeff King
2025-12-18 12:18 ` [PATCH 2/3] t5563: add missing end-of-line in HTTP header Jeff King
2025-12-18 13:41 ` Matthew John Cheetham
2025-12-19 7:32 ` Jeff King
2025-12-18 12:22 ` [PATCH 3/3] t5563: relax whitespace assumptions for unfolded headers Jeff King
2025-12-18 13:45 ` Matthew John Cheetham
2025-12-18 12:37 ` [PATCH 0/3] test-suite fixes for upcoming curl 8.18.0 Daniel Stenberg
2025-12-18 16:49 ` Daniel Stenberg
2025-12-19 8:04 ` Jeff King
2025-12-19 8:47 ` Daniel Stenberg
2025-12-19 23:23 ` Jeff King [this message]
2025-12-20 2:14 ` Junio C Hamano
2025-12-19 7:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219232357.GA3960837@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=daniel@haxx$(echo .)se \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mjcheetham@outlook$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox