From: Matthew Dodd <mats.dodd12@gmail•com>
To: git@vger•kernel.org
Cc: Brandon Williams <bmwill@google•com>,
Junio C Hamano <gitster@pobox•com>,
Johannes Schindelin <Johannes.Schindelin@gmx•de>,
Mats-Dodd <mats.dodd12@gmail•com>
Subject: [PATCH 0/2] Fix shallow clone with ref-in-want enabled
Date: Wed, 24 Dec 2025 01:35:02 +0100 [thread overview]
Message-ID: <20251224003504.52660-1-mats.dodd12@gmail.com> (raw)
From: Mats-Dodd <mats.dodd12@gmail•com>
The ref-in-want feature (uploadpack.allowRefInWant) has been broken with
shallow clones since it was introduced in 516e2b76bdc (upload-pack:
implement ref-in-want, 2018-06-27). When enabled, shallow clones fail
with:
fatal: expected 'packfile', received 'shallow-info'
The server sends protocol v2 sections in the wrong order, violating the
specification in Documentation/gitprotocol-v2.adoc and client expectations
in fetch-pack.c.
This series:
1. Fixes the section ordering in upload-pack.c (swap two lines)
2. Adds a regression test for shallow clone + ref-in-want
Mats-Dodd (2):
upload-pack: send shallow-info before wanted-refs in protocol v2
t5703: add test for shallow fetch with ref-in-want
t/t5703-upload-pack-ref-in-want.sh | 9 +++++++++
upload-pack.c | 2 +-
2 files changed, 10 insertions(+), 1 deletion(-)
base-commit: 9a2fb147f2c61d0cab52c883e7e26f5b7948e3ed
--
2.47.0
next reply other threads:[~2025-12-24 0:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 0:35 Matthew Dodd [this message]
2025-12-24 0:35 ` [PATCH 1/2] upload-pack: send shallow-info before wanted-refs in protocol v2 Matthew Dodd
2026-01-05 13:00 ` Patrick Steinhardt
2025-12-24 0:35 ` [PATCH 2/2] t5703: add test for shallow fetch with ref-in-want Matthew Dodd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251224003504.52660-1-mats.dodd12@gmail.com \
--to=mats.dodd12@gmail$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=bmwill@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox