* [PATCH v2] t1300: use test helpers instead of shell primitives
@ 2026-01-02 9:46 pushkarkumarsingh1970
0 siblings, 0 replies; only message in thread
From: pushkarkumarsingh1970 @ 2026-01-02 9:46 UTC (permalink / raw)
To: git; +Cc: Pushkar Singh
From: Pushkar Singh <pushkarkumarsingh1970@gmail•com>
Replace plain "test -f" (regular file checks) with "test_path_is_file" and "test -h"
(symbolic link checks) with "test_path_is_symlink". The test framework helpers
provide clearer diagnostics and better consistency across the test suite.
Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail•com>
---
v2: expand commit message to clarify that
- test -f checks regular files
- test -h checks symbolic links
t/t1300-config.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t1300-config.sh b/t/t1300-config.sh
index 358d636379..9850fcd5b5 100755
--- a/t/t1300-config.sh
+++ b/t/t1300-config.sh
@@ -1232,12 +1232,12 @@ test_expect_success SYMLINKS 'symlinked configuration' '
test_when_finished "rm myconfig" &&
ln -s notyet myconfig &&
git config --file=myconfig test.frotz nitfol &&
- test -h myconfig &&
- test -f notyet &&
+ test_path_is_symlink myconfig &&
+ test_path_is_file notyet &&
test "z$(git config --file=notyet test.frotz)" = znitfol &&
git config --file=myconfig test.xyzzy rezrov &&
- test -h myconfig &&
- test -f notyet &&
+ test_path_is_symlink myconfig &&
+ test_path_is_file notyet &&
cat >expect <<-\EOF &&
nitfol
rezrov
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-01-02 9:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-02 9:46 [PATCH v2] t1300: use test helpers instead of shell primitives pushkarkumarsingh1970
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox