public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
* [PATCH] t2021: use test helpers instead of shell primitives
@ 2026-01-02 11:03 pushkarkumarsingh1970
  0 siblings, 0 replies; only message in thread
From: pushkarkumarsingh1970 @ 2026-01-02 11:03 UTC (permalink / raw)
  To: git; +Cc: Pushkar Singh

From: Pushkar Singh <pushkarkumarsingh1970@gmail•com>

The tests here used plain `test -f` and `test -h` checks. Replacing them
with `test_path_is_file` and `test_path_is_symlink` makes failures easier
to understand and keeps the test style consistent with the rest of the
suite.

Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail•com>
---
 t/t2021-checkout-overwrite.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t2021-checkout-overwrite.sh b/t/t2021-checkout-overwrite.sh
index a5c03d5d4a..38c41ae373 100755
--- a/t/t2021-checkout-overwrite.sh
+++ b/t/t2021-checkout-overwrite.sh
@@ -27,7 +27,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' '
 	git rm --cached a/b &&
 	git commit -m "un-track the file" &&
 	test_must_fail git checkout start &&
-	test -f a/b
+	test_path_is_file a/b
 '
 
 test_expect_success 'create a commit where dir a/b changed to symlink' '
@@ -49,7 +49,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' '
 
 test_expect_success SYMLINKS 'the symlink remained' '
 
-	test -h a/b
+	test_path_is_symlink a/b
 '
 
 test_expect_success 'cleanup after previous symlink tests' '
-- 
2.43.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-01-02 11:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-02 11:03 [PATCH] t2021: use test helpers instead of shell primitives pushkarkumarsingh1970

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox