From: Jeff King <peff@peff•net>
To: git@vger•kernel.org
Subject: [PATCH 1/3] quote.h: bump strvec forward declaration to the top
Date: Mon, 18 May 2026 21:19:01 -0400 [thread overview]
Message-ID: <20260519011901.GA1615870@coredump.intra.peff.net> (raw)
In-Reply-To: <20260519011837.GA1615637@coredump.intra.peff.net>
We usually put forward declarations at the top of header files, rather
than next to the functions that need them. In theory placing it next to
the function has some explanatory value, but it's also just as likely to
become stale if other uses are added.
Signed-off-by: Jeff King <peff@peff•net>
---
quote.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/quote.h b/quote.h
index 0300c29104..400397b11a 100644
--- a/quote.h
+++ b/quote.h
@@ -2,6 +2,7 @@
#define QUOTE_H
struct strbuf;
+struct strvec;
extern int quote_path_fully;
@@ -77,7 +78,6 @@ int sq_dequote_to_argv(char *arg, const char ***argv, int *nr, int *alloc);
* still modify arg in place, but unlike sq_dequote_to_argv, the strvec
* will duplicate and take ownership of the strings.
*/
-struct strvec;
int sq_dequote_to_strvec(char *arg, struct strvec *);
int unquote_c_style(struct strbuf *, const char *quoted, const char **endp);
--
2.54.0.524.g198262df96
next prev parent reply other threads:[~2026-05-19 1:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 1:18 [PATCH 0/3] small quote.[ch] cleanup Jeff King
2026-05-19 1:19 ` Jeff King [this message]
2026-05-19 1:19 ` [PATCH 2/3] quote: drop sq_dequote_to_argv() Jeff King
2026-05-19 1:20 ` [PATCH 3/3] quote: simplify internals of dequoting Jeff King
2026-05-19 3:19 ` [PATCH 0/3] small quote.[ch] cleanup Junio C Hamano
2026-05-21 11:39 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519011901.GA1615870@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox