From: Patrick Steinhardt <ps@pks•im>
To: Junio C Hamano <gitster@pobox•com>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: [PATCH 0/3] small quote.[ch] cleanup
Date: Thu, 21 May 2026 13:39:36 +0200 [thread overview]
Message-ID: <ag7u-LkIyYvnhtfX@pks.im> (raw)
In-Reply-To: <xmqqjyt084sn.fsf@gitster.g>
On Tue, May 19, 2026 at 12:19:20PM +0900, Junio C Hamano wrote:
> Jeff King <peff@peff•net> writes:
>
> > I noticed some unused code while looking at an unrelated topic. So
> > here's a small cleanup.
> >
> > [1/3]: quote.h: bump strvec forward declaration to the top
> > [2/3]: quote: drop sq_dequote_to_argv()
> > [3/3]: quote: simplify internals of dequoting
> >
> > quote.c | 21 ++-------------------
> > quote.h | 14 ++++----------
> > 2 files changed, 6 insertions(+), 29 deletions(-)
> >
> > -Peff
>
> These were very straight-forward and pleasant to read. Queued.
> Thanks.
Indeed, all of these steps make sense to me. Thanks!
Patrick
prev parent reply other threads:[~2026-05-21 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 1:18 [PATCH 0/3] small quote.[ch] cleanup Jeff King
2026-05-19 1:19 ` [PATCH 1/3] quote.h: bump strvec forward declaration to the top Jeff King
2026-05-19 1:19 ` [PATCH 2/3] quote: drop sq_dequote_to_argv() Jeff King
2026-05-19 1:20 ` [PATCH 3/3] quote: simplify internals of dequoting Jeff King
2026-05-19 3:19 ` [PATCH 0/3] small quote.[ch] cleanup Junio C Hamano
2026-05-21 11:39 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag7u-LkIyYvnhtfX@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox