From: Abhijeet Sonar <abhijeet.nkt@gmail•com>
To: Karthik Nayak <karthik.188@gmail•com>, git@vger•kernel.org
Cc: Paul Millar <paul.millar@desy•de>,
Junio C Hamano <gitster@pobox•com>,
Phillip Wood <phillip.wood123@gmail•com>,
Elijah Newren <newren@gmail•com>, Jeff King <peff@peff•net>
Subject: Re: [PATCH v5] describe: refresh the index when 'broken' flag is used
Date: Wed, 26 Jun 2024 17:36:25 +0530 [thread overview]
Message-ID: <2e80306e-2474-4254-95eb-c2902a56ffdd@gmail.com> (raw)
In-Reply-To: <CAOLa=ZRz2KEGiBnX1YP6JG1nXXHLfw9A3dHKO3s_ViLhq+bWww@mail.gmail.com>
On 26/06/24 17:00, Karthik Nayak wrote:
> Not worth a reroll, but you don't have to create file.new twice.
Actually, now that I think of it, those two were better off being
separate tests. It might so happen the first call to describe refreshes
the index, due to which the second call with the --broken option does
not bug-out in the way it would if the command was run by itself.
Having them separate would give them enough isolation so that previous
command does not interfere with the later.
>> Range-diff against v4:
>> 1: 1da5fa48d9 ! 1: 52f590b70f describe: refresh the index when 'broken' flag is used
>> @@ builtin/describe.c: int cmd_describe(int argc, const char **argv, const char *pr
>> + cp.git_cmd = 1;
>> + cp.no_stdin = 1;
>> + cp.no_stdout = 1;
>> -+ run_command(&cp);
>> -+ strvec_clear(&cp.args);
>> ++ if (run_command(&cp))
>> ++ child_process_clear(&cp);
>> +
>> strvec_pushv(&cp.args, diff_index_args);
>> cp.git_cmd = 1;
>> --
>> 2.45.2.606.g9005149a4a.dirty
>
> Other than this, this looks good to me.
I am not sure if I follow this one. Am I expected to not share the
struct child_process between the two sub-process calls?
Thanks
next prev parent reply other threads:[~2024-06-26 12:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 13:35 [PATCH v3] describe: refresh the index when 'broken' flag is used Abhijeet Sonar
2024-06-25 15:59 ` Junio C Hamano
2024-06-25 16:05 ` Junio C Hamano
2024-06-26 11:16 ` Karthik Nayak
2024-06-26 6:11 ` Abhijeet Sonar
2024-06-26 6:37 ` [PATCH v4] " Abhijeet Sonar
2024-06-26 6:50 ` Abhijeet Sonar
2024-06-26 6:52 ` [PATCH v5] " Abhijeet Sonar
2024-06-26 11:30 ` Karthik Nayak
2024-06-26 12:06 ` Abhijeet Sonar [this message]
2024-06-26 15:34 ` Re* " Junio C Hamano
2024-06-26 16:17 ` Junio C Hamano
2024-06-26 17:29 ` Abhijeet Sonar
2024-06-26 17:35 ` Junio C Hamano
2024-06-26 17:45 ` Junio C Hamano
2024-06-26 18:07 ` Abhijeet Sonar
2024-06-26 18:49 ` Junio C Hamano
2024-06-26 20:34 ` Jeff King
2024-06-27 0:33 ` Jeff King
2024-06-26 21:23 ` Karthik Nayak
2024-06-26 14:59 ` Junio C Hamano
2024-06-26 18:31 ` Junio C Hamano
2024-06-26 19:08 ` [PATCH v7] " Abhijeet Sonar
2024-06-26 19:25 ` Abhijeet Sonar
2024-06-27 6:01 ` Abhijeet Sonar
2024-06-27 15:47 ` Junio C Hamano
2024-06-27 17:33 ` Abhijeet Sonar
2024-06-30 16:12 ` Karthik Nayak
2024-07-01 19:06 ` Junio C Hamano
2024-07-02 10:13 ` Karthik Nayak
2024-07-03 18:17 ` Junio C Hamano
2024-07-03 20:41 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e80306e-2474-4254-95eb-c2902a56ffdd@gmail.com \
--to=abhijeet.nkt@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=karthik.188@gmail$(echo .)com \
--cc=newren@gmail$(echo .)com \
--cc=paul.millar@desy$(echo .)de \
--cc=peff@peff$(echo .)net \
--cc=phillip.wood123@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox