From: Junio C Hamano <gitster@pobox•com>
To: Abhijeet Sonar <abhijeet.nkt@gmail•com>
Cc: git@vger•kernel.org, Paul Millar <paul.millar@desy•de>,
Phillip Wood <phillip.wood123@gmail•com>,
Elijah Newren <newren@gmail•com>, Jeff King <peff@peff•net>
Subject: Re: [PATCH v7] describe: refresh the index when 'broken' flag is used
Date: Thu, 27 Jun 2024 08:47:02 -0700 [thread overview]
Message-ID: <xmqqfrsyv155.fsf@gitster.g> (raw)
In-Reply-To: <03628ece-4f47-40d5-a926-acce684a21e5@gmail.com> (Abhijeet Sonar's message of "Thu, 27 Jun 2024 00:55:01 +0530")
Abhijeet Sonar <abhijeet.nkt@gmail•com> writes:
> I have a question:
>
> Why does --dirty code path also not call git-update-index and instead does
>
> setup_work_tree();
> prepare_repo_settings(the_repository);
> the_repository->settings.command_requires_full_index = 0;
> repo_read_index(the_repository);
> refresh_index(...);
> fd = repo_hold_locked_index(...);
> if (0 <= fd)
> repo_update_index_if_able(the_repository, &index_lock);
>
> I assume they are equivalent?
Now we are going back full circles ;-)?
Your earliest attempt indeed copied the above to the code paths used
to handle "--broken", but then Phillip corrected the course
https://lore.kernel.org/git/054c6ac1-4714-4600-afa5-7e9b6e9b0e72@gmail.com/
to avoid triggering an in-process error and instead run an
equivalent "update-index --refresh" via the run_command() interface,
so that we can catch potential errors. The code in the more recent
rounds of your patch uses that, no?
> The commit which introduced this --
> bb571486ae93d02746c4bcc8032bde306f6d399a (describe: Refresh the index
> when run with --dirty) seems to be for the same objective as mu patch.
Yes, but the cited message above explains the reason why the two
code paths in your patch use different implementations, I would
think.
next prev parent reply other threads:[~2024-06-27 15:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 13:35 [PATCH v3] describe: refresh the index when 'broken' flag is used Abhijeet Sonar
2024-06-25 15:59 ` Junio C Hamano
2024-06-25 16:05 ` Junio C Hamano
2024-06-26 11:16 ` Karthik Nayak
2024-06-26 6:11 ` Abhijeet Sonar
2024-06-26 6:37 ` [PATCH v4] " Abhijeet Sonar
2024-06-26 6:50 ` Abhijeet Sonar
2024-06-26 6:52 ` [PATCH v5] " Abhijeet Sonar
2024-06-26 11:30 ` Karthik Nayak
2024-06-26 12:06 ` Abhijeet Sonar
2024-06-26 15:34 ` Re* " Junio C Hamano
2024-06-26 16:17 ` Junio C Hamano
2024-06-26 17:29 ` Abhijeet Sonar
2024-06-26 17:35 ` Junio C Hamano
2024-06-26 17:45 ` Junio C Hamano
2024-06-26 18:07 ` Abhijeet Sonar
2024-06-26 18:49 ` Junio C Hamano
2024-06-26 20:34 ` Jeff King
2024-06-27 0:33 ` Jeff King
2024-06-26 21:23 ` Karthik Nayak
2024-06-26 14:59 ` Junio C Hamano
2024-06-26 18:31 ` Junio C Hamano
2024-06-26 19:08 ` [PATCH v7] " Abhijeet Sonar
2024-06-26 19:25 ` Abhijeet Sonar
2024-06-27 6:01 ` Abhijeet Sonar
2024-06-27 15:47 ` Junio C Hamano [this message]
2024-06-27 17:33 ` Abhijeet Sonar
2024-06-30 16:12 ` Karthik Nayak
2024-07-01 19:06 ` Junio C Hamano
2024-07-02 10:13 ` Karthik Nayak
2024-07-03 18:17 ` Junio C Hamano
2024-07-03 20:41 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfrsyv155.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=abhijeet.nkt@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=newren@gmail$(echo .)com \
--cc=paul.millar@desy$(echo .)de \
--cc=peff@peff$(echo .)net \
--cc=phillip.wood123@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox