* [PATCH 1/4] git-gui: run auto maintenance on commit
[not found] <cover.1772573786.git.contrib-git@wolfgangfaust.com>
@ 2026-03-06 5:19 ` Wolfgang Faust
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Faust @ 2026-03-06 5:19 UTC (permalink / raw)
To: git; +Cc: Johannes Sixt
This implements the same behavior as seen in builtin/commit.c:
run auto maintenance between rerere and the post-commit hook.
Signed-off-by: Wolfgang Faust <contrib-git@wolfgangfaust•com>
---
This always detaches rather than honoring autoDetach (unlike
run_auto_maintenance()) because I can't think of a circumstance where
you'd want the GUI to block.
git-gui/lib/commit.tcl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl
index 89eb8c7b73..4b07cb3bbb 100644
--- a/git-gui/lib/commit.tcl
+++ b/git-gui/lib/commit.tcl
@@ -477,6 +477,12 @@ A rescan will be automatically started now.
catch {git rerere}
}
+ # -- Run auto maintenance (e.g. garbage collection)
+ #
+ if {[is_config_true maintenance.auto]} {
+ catch {exec git maintenance run --auto --quiet --detach}
+ }
+
# -- Run the post-commit hook.
#
set fd_ph [githook_read post-commit]
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 0/4] run auto maintenance in git-gui
@ 2026-03-06 5:15 Wolfgang Faust
2026-03-06 5:26 ` [PATCH 1/4] git-gui: run auto maintenance on commit Wolfgang Faust
0 siblings, 1 reply; 2+ messages in thread
From: Wolfgang Faust @ 2026-03-06 5:15 UTC (permalink / raw)
To: git; +Cc: Johannes Sixt, Birger Skogeng Pedersen, Pratyush Yadav,
Marc Branchaud
Resurrecting the 2019 conversation "git-gui: disable the "loose objects
popup" dialog?":
<https://lore.kernel.org/git/CAGr--=K15nUcnsJWOP87uMMjeQmTgAeO_6hnr12k2zuNQjNyBw@mail.gmail.com/t/#u>
The consensus there seems to be that git's auto maintenance is now
good enough and if git-gui implemented the same behavior as `git commit`
then the "repository currently has approximately %i loose objects"
dialog would no longer be necessary. This patch series implements that.
Wolfgang Faust (4):
git-gui: run auto maintenance on commit
git-gui: remove hint_gc dialog
git-gui: remove "Compress Database" feature
scalar: remove obsolete gui.GCWarning setting
Documentation/config/gui.adoc | 5 -----
Documentation/scalar.adoc | 6 ------
git-gui/git-gui.sh | 6 ------
git-gui/lib/commit.tcl | 6 ++++++
git-gui/lib/database.tcl | 40 -----------------------------------
git-gui/po/bg.po | 22 -------------------
git-gui/po/de.po | 27 -----------------------
git-gui/po/el.po | 27 -----------------------
git-gui/po/fr.po | 28 ------------------------
git-gui/po/hu.po | 27 -----------------------
git-gui/po/it.po | 26 -----------------------
git-gui/po/ja.po | 26 -----------------------
git-gui/po/nb.po | 27 -----------------------
git-gui/po/pt_br.po | 27 -----------------------
git-gui/po/pt_pt.po | 27 -----------------------
git-gui/po/ru.po | 20 ------------------
git-gui/po/sv.po | 27 -----------------------
git-gui/po/vi.po | 27 -----------------------
git-gui/po/zh_cn.po | 26 -----------------------
scalar.c | 1 -
t/t9210-scalar.sh | 20 +++++++++---------
21 files changed, 16 insertions(+), 432 deletions(-)
base-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5
--
2.52.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/4] git-gui: run auto maintenance on commit
2026-03-06 5:15 [PATCH 0/4] run auto maintenance in git-gui Wolfgang Faust
@ 2026-03-06 5:26 ` Wolfgang Faust
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Faust @ 2026-03-06 5:26 UTC (permalink / raw)
To: git; +Cc: Johannes Sixt
This implements the same behavior as seen in builtin/commit.c:
run auto maintenance between rerere and the post-commit hook.
Signed-off-by: Wolfgang Faust <contrib-git@wolfgangfaust•com>
---
(This email was previously accidentally sent with incorrect threading.
Please ignore the dup and bear with me as I figure out send-email...)
This always detaches rather than honoring autoDetach (unlike
run_auto_maintenance()) because I can't think of a circumstance where
you'd want the GUI to block.
git-gui/lib/commit.tcl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl
index 89eb8c7b73..4b07cb3bbb 100644
--- a/git-gui/lib/commit.tcl
+++ b/git-gui/lib/commit.tcl
@@ -477,6 +477,12 @@ A rescan will be automatically started now.
catch {git rerere}
}
+ # -- Run auto maintenance (e.g. garbage collection)
+ #
+ if {[is_config_true maintenance.auto]} {
+ catch {exec git maintenance run --auto --quiet --detach}
+ }
+
# -- Run the post-commit hook.
#
set fd_ph [githook_read post-commit]
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-06 5:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1772573786.git.contrib-git@wolfgangfaust.com>
2026-03-06 5:19 ` [PATCH 1/4] git-gui: run auto maintenance on commit Wolfgang Faust
2026-03-06 5:15 [PATCH 0/4] run auto maintenance in git-gui Wolfgang Faust
2026-03-06 5:26 ` [PATCH 1/4] git-gui: run auto maintenance on commit Wolfgang Faust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox