From: Siddh Raman Pant <siddh.raman.pant@oracle•com>
To: "git@vger•kernel.org" <git@vger•kernel.org>,
"calvinwan@google•com" <calvinwan@google•com>,
"gitster@pobox•com" <gitster@pobox•com>,
"newren@gmail•com" <newren@gmail•com>,
"sandals@crustytoothpaste•net" <sandals@crustytoothpaste•net>,
"ps@pks•im" <ps@pks•im>,
"code@khaugsbakk•name" <code@khaugsbakk•name>
Subject: Re: [PATCH 7/9] notes: support an external command to display notes
Date: Thu, 21 May 2026 04:12:41 +0000 [thread overview]
Message-ID: <4086055f59eec99f94847a1b37c684a084f08e0b.camel@oracle.com> (raw)
In-Reply-To: <ag5b4O7-k-3QBR4W@fruit.crustytoothpaste.net>
[-- Attachment #1: Type: text/plain, Size: 2380 bytes --]
On Thu, May 21 2026 at 06:42:00 +0530, brian m. carlson wrote:
> > Assisted-by: Codex:gpt-5.5-xhigh-fast
>
> Just a question here: was this written in whole or in part by Codex, or
> was it just used as a reference to ask questions? I ask because the
> style of notes-external.c differs quite a bit from the style we use (for
> one, the horizontal rule comments) and we have this in
AI tools typically don't generate comments in code like in this series,
you can see by trying out for yourself. Each comment is hand-written by
me. Sorry, I'll remove those lines in v2 after this discussion.
AI was used for review, and providing the initial skeletal, which I
changed significantly.
> SubmittingPatches:
>
> The Developer's Certificate of Origin requires contributors to certify
> that they know the origin of their contributions to the project and
> that they have the right to submit it under the project's license.
> It's not yet clear that this can be legally satisfied when submitting
> significant amount of content that has been generated by AI tools.
>
> [...]
>
> To avoid these issues, we will reject anything that looks AI
> generated, that sounds overly formal or bloated, that looks like AI
> slop, that looks good on the surface but makes no sense, or that
> senders don’t understand or cannot explain.
Please tell me why this change is a slop and doesn't make sense.
If I wanted to mislead here, I would not have used the "Assisted-by"
trailer, which is now being used in kernel land:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-assisted-by
There have already been commits in the git.git history having the
Assisted-by trailer.
> I'll note that it also has a lot of global variables, which are common
> in the codebase but we're trying to move away from,
Is there a new facility to store the config without a global variable?
If the issue is the number, I can make a housing struct if you want.
> and it's more
> verbose in commenting than we'd normally see elsewhere in the codebase.
I added comments to explain the code clearly as it's being followed,
especially since this is a new feature and I wanted the intent to be
clear.
If you could tell me which comments to remove, that would be great.
Thanks,
Siddh
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-05-21 4:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 16:30 [PATCH 0/9] Add support for an external command for fetching notes Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 1/9] Documentation/git-range-diff: add missing notes options in synopsis Siddh Raman Pant
2026-05-19 23:47 ` Junio C Hamano
2026-05-20 7:00 ` Siddh Raman Pant
2026-05-21 0:28 ` Junio C Hamano
2026-05-21 4:13 ` Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 2/9] notes: convert raw arg in format_display_notes() to bool Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 3/9] wrapper: add sleep_nanosec Siddh Raman Pant
2026-05-19 23:50 ` Junio C Hamano
2026-05-20 7:07 ` Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 4/9] run-command: add support for timeout in command finisher Siddh Raman Pant
2026-05-21 7:21 ` Johannes Sixt
2026-05-21 8:39 ` Oswald Buddenhagen
2026-05-21 9:59 ` Siddh Raman Pant
2026-05-21 14:36 ` Johannes Sixt
2026-05-22 0:10 ` Junio C Hamano
2026-05-22 5:46 ` Siddh Raman Pant
2026-05-22 5:10 ` Jeff King
2026-05-22 5:59 ` Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 5/9] wrapper: add support for timeout and deadline in read helpers Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 6/9] t3301: cover generic displayed notes behavior Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 7/9] notes: support an external command to display notes Siddh Raman Pant
2026-05-20 0:03 ` Junio C Hamano
2026-05-20 6:59 ` Siddh Raman Pant
2026-05-21 1:12 ` brian m. carlson
2026-05-21 4:12 ` Siddh Raman Pant [this message]
2026-05-21 21:18 ` brian m. carlson
2026-05-19 16:30 ` [PATCH 8/9] Documentation: document external notes command options Siddh Raman Pant
2026-05-19 16:30 ` [PATCH 9/9] t: add tests for external notes command Siddh Raman Pant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4086055f59eec99f94847a1b37c684a084f08e0b.camel@oracle.com \
--to=siddh.raman.pant@oracle$(echo .)com \
--cc=calvinwan@google$(echo .)com \
--cc=code@khaugsbakk$(echo .)name \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=newren@gmail$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox