From: Han-Wen Nienhuys <hanwen@xs4all•nl>
To: Junio C Hamano <junkio@cox•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Install git-sh-setup.sh into $(prefix)/share/git-core. Call with explicit path.
Date: Sat, 09 Dec 2006 14:08:27 +0100 [thread overview]
Message-ID: <457AB54B.8070107@xs4all.nl> (raw)
In-Reply-To: <7v3b7qi0b4.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano escreveu:
> Eric Wong <normalperson@yhbt•net> writes:
>
>> Han-Wen Nienhuys <hanwen@xs4all•nl> wrote:
>>> git-sh-setup isn't a 'normal' binary, in that it should be called by
>>> bash only and not run in a subshell. Therefore, it should not be installed
>>> in a executable directory, but rather in $prefix/share/git-core/
>> This seems to break existing hooks, or at least old repositories can
>> be stuck using an old version of git-sh-setup in those hooks.
>
> Honestly speaking, I do not think this patch is worth it.
> People who care deeply enough should just use gitexecdir that is
> separate from bindir.
And how about coding the path of git-sh-setup (in <prefix>/bin/git-sh-setup)
in the shell scripts? This will ensure that the sh-setup is the one
from the right package, but still retain backward compatibility for
scripts.
--
next prev parent reply other threads:[~2006-12-09 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 17:13 [PATCH] Install git-sh-setup.sh into $(prefix)/share/git-core. Call with explicit path Han-Wen Nienhuys
2006-12-08 19:11 ` Nguyen Thai Ngoc Duy
2006-12-08 20:50 ` Han-Wen Nienhuys
2006-12-08 19:37 ` Eric Wong
2006-12-08 20:45 ` Junio C Hamano
2006-12-09 13:08 ` Han-Wen Nienhuys [this message]
2006-12-09 21:35 ` Junio C Hamano
2006-12-09 23:40 ` Han-Wen Nienhuys
2006-12-10 0:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457AB54B.8070107@xs4all.nl \
--to=hanwen@xs4all$(echo .)nl \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox