From: Han-Wen Nienhuys <hanwen@xs4all•nl>
To: Junio C Hamano <junkio@cox•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Install git-sh-setup.sh into $(prefix)/share/git-core. Call with explicit path.
Date: Sun, 10 Dec 2006 00:40:49 +0100 [thread overview]
Message-ID: <457B4981.2030408@xs4all.nl> (raw)
In-Reply-To: <7v1wn8ah2k.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano escreveu:
> Han-Wen Nienhuys <hanwen@xs4all•nl> writes:
>
>> And how about coding the path of git-sh-setup (in <prefix>/bin/git-sh-setup)
>> in the shell scripts? This will ensure that the sh-setup is the one
>> from the right package, but still retain backward compatibility for
>> scripts.
>
> Hardcoding $(bin)/git-sh-setup is a non-starter; it breaks
> GIT_EXEC_PATH convention to allow users to override it.
> In other words, I do not know what real problem you are trying
> to solve.
The real problem is that git is nonstandard to wrap around:
scripts like git-sh-setup need special attention, because they don't work
with
exec /some/where/else/git-sh-setup "$@"
I admit is a small problem, but IMO that's not an argument not to solve it.
--
next prev parent reply other threads:[~2006-12-09 23:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 17:13 [PATCH] Install git-sh-setup.sh into $(prefix)/share/git-core. Call with explicit path Han-Wen Nienhuys
2006-12-08 19:11 ` Nguyen Thai Ngoc Duy
2006-12-08 20:50 ` Han-Wen Nienhuys
2006-12-08 19:37 ` Eric Wong
2006-12-08 20:45 ` Junio C Hamano
2006-12-09 13:08 ` Han-Wen Nienhuys
2006-12-09 21:35 ` Junio C Hamano
2006-12-09 23:40 ` Han-Wen Nienhuys [this message]
2006-12-10 0:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457B4981.2030408@xs4all.nl \
--to=hanwen@xs4all$(echo .)nl \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox