From: Johannes Sixt <J.Sixt@eudaptics•com>
To: git@vger•kernel.org
Subject: Re: [PATCH] fetch-pack: remove --keep-auto and make it the default.
Date: Fri, 26 Jan 2007 09:37:15 +0100 [thread overview]
Message-ID: <45B9BDBB.E9C65371@eudaptics.com> (raw)
In-Reply-To: 7vejpiaj2f.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
>
> Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:
>
> > On Wed, 24 Jan 2007, Junio C Hamano wrote:
> >
> >> Ok, how about this, on top of the previous ones?
> >
> > Thanks!
> >
> >> @@ -653,6 +663,8 @@ int main(int argc, char **argv)
> >> struct stat st;
> >>
> >> setup_git_directory();
> >> + setup_ident();
> >> + git_config(fetch_pack_config);
> >
> > Why do you need setup_ident()?
>
> Because presumably you would be updating the reflog that records
> who did the fetch?
>
> But then we should do the same ignore_missing_committer_name()
> we have in receive-pack to allow anonymous fetchers to fetch
> from outside world, I guess.
Instead of using ignore_missing_committer_name(), use
get_committer_info(0) in refs.c. cherry-pick 4feaf032d3 from my tree at
git://repo.or.cz/git/mingw.git if you want.
Although this approach leaves the name+email in the reflog entry empty
instead of writing "unkown"...
-- Hannes
next prev parent reply other threads:[~2007-01-26 8:36 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-21 8:56 [Announce] GIT v1.5.0-rc2 Junio C Hamano
2007-01-21 9:40 ` Jakub Narebski
2007-01-21 10:52 ` Junio C Hamano
2007-01-21 11:08 ` Johannes Schindelin
2007-01-23 18:12 ` Bill Lear
2007-01-23 19:12 ` Johannes Schindelin
2007-01-23 20:12 ` Bill Lear
2007-01-23 20:22 ` Uwe Kleine-König
2007-01-23 20:31 ` Bill Lear
2007-01-24 10:06 ` Uwe Kleine-König
2007-01-23 20:22 ` Johannes Schindelin
2007-01-23 21:09 ` Peter Baumann
2007-01-23 21:54 ` Bill Lear
2007-01-23 20:32 ` Linus Torvalds
2007-01-24 17:54 ` Mark Nudelman
2007-01-24 18:18 ` Linus Torvalds
2007-01-24 19:21 ` Linus Torvalds
2007-01-24 23:23 ` Junio C Hamano
2007-03-27 0:07 ` Mark Nudelman
2007-01-21 11:20 ` Junio C Hamano
2007-01-21 13:42 ` Bill Lear
2007-01-21 13:52 ` Bill Lear
[not found] ` <20070121145805.735815@dial-up-mi-352.lombardiacom.it>
2007-01-21 15:02 ` Michael
2007-01-21 21:26 ` Johannes Schindelin
2007-01-21 21:33 ` Jakub Narebski
2007-01-21 22:01 ` Johannes Schindelin
2007-01-21 22:24 ` Jakub Narebski
2007-01-21 13:43 ` Willy Tarreau
2007-01-21 15:06 ` Jakub Narebski
2007-01-21 18:58 ` Junio C Hamano
2007-01-21 19:49 ` H. Peter Anvin
2007-01-22 17:23 ` Nicolas Pitre
2007-01-21 20:01 ` Horst H. von Brand
2007-01-22 1:27 ` Junio C Hamano
2007-01-21 19:46 ` Horst H. von Brand
2007-01-21 20:51 ` Junio C Hamano
2007-01-21 21:55 ` Johannes Schindelin
2007-01-21 22:45 ` Jakub Narebski
2007-01-21 22:52 ` Johannes Schindelin
2007-01-21 23:08 ` Jakub Narebski
2007-01-21 23:13 ` Johannes Schindelin
2007-01-21 23:36 ` Jakub Narebski
2007-01-22 0:55 ` Junio C Hamano
2007-01-22 6:25 ` Junio C Hamano
2007-01-23 6:47 ` [PATCH 1/2] Refactor the pack header reading function out of receive-pack.c Junio C Hamano
2007-01-23 6:47 ` [PATCH 2/2] Allow fetch-pack to decide keeping the fetched pack without exploding Junio C Hamano
2007-01-23 10:32 ` Johannes Schindelin
2007-01-23 10:55 ` Jakub Narebski
2007-01-23 11:07 ` code movements in diffs, was " Johannes Schindelin
2007-01-23 16:01 ` Nicolas Pitre
2007-01-25 1:14 ` [PATCH] fetch-pack: remove --keep-auto and make it the default Junio C Hamano
2007-01-25 8:23 ` Johannes Schindelin
2007-01-25 21:32 ` Junio C Hamano
2007-01-25 23:46 ` Johannes Schindelin
2007-01-26 3:05 ` Junio C Hamano
2007-01-26 3:30 ` [PATCH] Allow non-developer to clone, checkout and fetch easier Junio C Hamano
2007-01-26 14:20 ` Alex Riesen
2007-01-26 8:37 ` Johannes Sixt [this message]
2007-01-25 1:14 ` [PATCH] Consolidate {receive,fetch}.unpackLimit Junio C Hamano
2007-01-25 3:32 ` Nicolas Pitre
2007-01-25 5:14 ` Shawn O. Pearce
2007-01-23 16:15 ` [PATCH 2/2] Allow fetch-pack to decide keeping the fetched pack without exploding Linus Torvalds
2007-01-23 16:28 ` David Kågedal
2007-01-23 16:43 ` Johannes Schindelin
2007-01-23 17:22 ` Jakub Narebski
2007-01-22 18:08 ` [Announce] GIT v1.5.0-rc2 Carl Worth
2007-01-22 19:28 ` Junio C Hamano
2007-01-23 1:01 ` Carl Worth
2007-01-22 18:22 ` Jakub Narebski
2007-01-22 18:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B9BDBB.E9C65371@eudaptics.com \
--to=j.sixt@eudaptics$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox