From: Mark Levedahl <mdl123@verizon•net>
To: Sergey Vlasov <vsu@altlinux•ru>
Cc: git@vger•kernel.org, Junio C Hamano <junkio@cox•net>,
Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH] Clean up geometry save code in gitk.
Date: Sun, 11 Feb 2007 12:44:03 -0500 [thread overview]
Message-ID: <45CF55E3.9080508@verizon.net> (raw)
In-Reply-To: <20070211195643.b1f548f2.vsu@altlinux.ru>
Sergey Vlasov wrote:
> These two patches fix saving of the window position for me; however,
> some things still remain broken:
>
> - No matter what sizes of the commit tree, patch and filelist panes I
> set, on gitk restart they come up with their default sizes.
>
> - Sizes of commit tree columns are not saved properly - on every gitk
> restart the dividers are shifting more and more to the right.
>
> This is on Linux (x86_64) with Tk 8.4.13.
>
> I made two more patches which fix the above problems for me - please
> test them (in particular, someone needs to check that the Cygwin
> support is not broken - apparently something is different between Tk
> on Linux and Cygwin to create the problem with commit tree columns).
>
> See the followup messages.
>
> --
> Sergey Vlasov
>
I could not actually apply your patches, but your suggested changes were
simple enough to apply by hand:
1) I do notice the change in size of panes in the upper window on Cygwin
(hadn't noticed before but it is there), and your "-highlightthickness
0" tweak fixes that. Just for grins, I tried reenabling the "subtract 2"
strategy in place before, and that only makes the problem worse on Cygwin.
2) I don't see any effect of the "pane configure" tweak on Cygwin.
Haven't checked on Linux (don't have that here) so cannot comment.
Gotta say, the more I play with Tk, the more I wonder why anyone uses
anything else ;-) .
Mark
next prev parent reply other threads:[~2007-02-11 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-11 14:27 [PATCH] Make gitk save and restore the user set window position Mark Levedahl
2007-02-11 14:27 ` Mark Levedahl
2007-02-11 14:27 ` [PATCH] Clean up geometry save code in gitk Mark Levedahl
2007-02-11 16:56 ` Sergey Vlasov
2007-02-11 16:58 ` gitk: Fix restoring of pane sizes Sergey Vlasov
2007-02-11 16:58 ` gitk: Fix restoring of column widths in the commit tree Sergey Vlasov
2007-02-11 17:44 ` Mark Levedahl [this message]
2007-02-11 21:49 ` [PATCH] Make gitk save and restore the user set window position Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45CF55E3.9080508@verizon.net \
--to=mdl123@verizon$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=paulus@samba$(echo .)org \
--cc=vsu@altlinux$(echo .)ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox