From: Sergey Vlasov <vsu@altlinux•ru>
To: Mark Levedahl <mdl123@verizon•net>
Cc: git@vger•kernel.org, Junio C Hamano <junkio@cox•net>,
Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH] Clean up geometry save code in gitk.
Date: Sun, 11 Feb 2007 19:56:43 +0300 [thread overview]
Message-ID: <20070211195643.b1f548f2.vsu@altlinux.ru> (raw)
In-Reply-To: <1171204040779-git-send-email-mdl123@verizon.net>
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
Hello!
On Sun, 11 Feb 2007 09:27:20 -0500
Mark Levedahl <mdl123@verizon•net> wrote:
> gitk was saving widget sizes and positions when the main window was
> destroyed, which is after all child widgets are destroyed. The cure
> is to trap the WM_DELETE_WINDOW event before the gui is torn down. Also,
> the saved geometry was captured using "winfo geometry .", rather than
> "wm geometry ." Under Linux, these two return different answers and the
> latter one is correct.
> Leftover code was subtracting zero from several items before storing, an
> obvious noop now deleted.
These two patches fix saving of the window position for me; however,
some things still remain broken:
- No matter what sizes of the commit tree, patch and filelist panes I
set, on gitk restart they come up with their default sizes.
- Sizes of commit tree columns are not saved properly - on every gitk
restart the dividers are shifting more and more to the right.
This is on Linux (x86_64) with Tk 8.4.13.
I made two more patches which fix the above problems for me - please
test them (in particular, someone needs to check that the Cygwin
support is not broken - apparently something is different between Tk
on Linux and Cygwin to create the problem with commit tree columns).
See the followup messages.
--
Sergey Vlasov
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-02-11 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-11 14:27 [PATCH] Make gitk save and restore the user set window position Mark Levedahl
2007-02-11 14:27 ` Mark Levedahl
2007-02-11 14:27 ` [PATCH] Clean up geometry save code in gitk Mark Levedahl
2007-02-11 16:56 ` Sergey Vlasov [this message]
2007-02-11 16:58 ` gitk: Fix restoring of pane sizes Sergey Vlasov
2007-02-11 16:58 ` gitk: Fix restoring of column widths in the commit tree Sergey Vlasov
2007-02-11 17:44 ` [PATCH] Clean up geometry save code in gitk Mark Levedahl
2007-02-11 21:49 ` [PATCH] Make gitk save and restore the user set window position Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070211195643.b1f548f2.vsu@altlinux.ru \
--to=vsu@altlinux$(echo .)ru \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=mdl123@verizon$(echo .)net \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox