From: Michael Spang <mspang@uwaterloo•ca>
To: Junio C Hamano <junkio@cox•net>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH/RFD 4/3] t7300: Tests for git-clean using filenames with spaces/punctuation
Date: Sun, 06 May 2007 15:14:04 -0400 [thread overview]
Message-ID: <463E28FC.9080209@uwaterloo.ca> (raw)
In-Reply-To: <7vr6ptbx5g.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Michael Spang <mspang@uwaterloo•ca> writes:
>
>> Is this even properly solvable without making clean a builtin or
>> writing git-unescape?
>
> If you know how to use "xargs -0" and are willing to depend on
> the -0 GNU extension, then the answer is yes.
Right. But I do not think xargs can call a shell function. git-clean
does not just call git-rm directly. I guess git-clean could call
itself through xargs, but that might become confusing.
> I do not use git-clean myself, as I do not see what (I think) it
> tries to solve as a problem to begin with, so obviously I do not
> care too deeply about the command's implementation --- I just
> let it be there because there seem to be others who want it ---
> but if I were asked an advice on the right direction to proceed,
> I would probably suggest rewriting it in C.
That seems like the cleanest solution to me as well.
Cheers,
Michael Spang
prev parent reply other threads:[~2007-05-06 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <463E1705.2090201@gmail.com>
2007-05-06 18:09 ` [PATCH 2/3] dir.c: Omit non-excluded directories with dir->show_ignored Michael Spang
2007-05-06 19:42 ` Linus Torvalds
2007-05-06 20:18 ` Michael Spang
2007-05-07 2:35 ` Michael Spang
2007-05-06 18:09 ` [PATCH 3/3] Fix minor documentation errors Michael Spang
2007-05-06 18:09 ` [PATCH/RFD 4/3] t7300: Tests for git-clean using filenames with spaces/punctuation Michael Spang
2007-05-06 18:54 ` Junio C Hamano
2007-05-06 19:14 ` Michael Spang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463E28FC.9080209@uwaterloo.ca \
--to=mspang@uwaterloo$(echo .)ca \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox