From: Tommy Thorn <tommy-git@thorn•ws>
To: Toby Allsopp <Toby.Allsopp@navman•co.nz>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] git-p4: Fix indentation from tab to spaces
Date: Mon, 04 Feb 2008 14:18:35 -0800 [thread overview]
Message-ID: <47A78F3B.5090002@thorn.ws> (raw)
In-Reply-To: <87fxw8mp2w.fsf@nav-akl-pcn-343.mitacad.com>
Toby Allsopp wrote:
> Signed-off-by: Toby Allsopp <toby.allsopp@navman•co.nz>
> ---
> contrib/fast-import/git-p4 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index c17afae..781a0cb 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -1646,7 +1646,7 @@ class P4Clone(P4Sync):
> depotPath = args[0]
> depotDir = re.sub("(@[^@]*)$", "", depotPath)
> depotDir = re.sub("(#[^#]*)$", "", depotDir)
> - depotDir = re.sub(r"\.\.\.$", "", depotDir)
> + depotDir = re.sub(r"\.\.\.$", "", depotDir)
> depotDir = re.sub(r"/$", "", depotDir)
> return os.path.split(depotDir)[1]
>
>
Acked-by: Tommy Thorn <tommy-git@thorn•ws>
I'm not sure that happend, but I did have some issues sending the patch
that should be fixed now.
Nobody commented on the most important one - the fix for git-p4 memory
appetite.
Tommy
prev parent reply other threads:[~2008-02-04 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 20:41 [PATCH] git-p4: Fix indentation from tab to spaces Toby Allsopp
2008-02-04 22:18 ` Tommy Thorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A78F3B.5090002@thorn.ws \
--to=tommy-git@thorn$(echo .)ws \
--cc=Toby.Allsopp@navman$(echo .)co.nz \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox