public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
* [PATCH] git-p4: Fix indentation from tab to spaces
@ 2008-02-04 20:41 Toby Allsopp
  2008-02-04 22:18 ` Tommy Thorn
  0 siblings, 1 reply; 2+ messages in thread
From: Toby Allsopp @ 2008-02-04 20:41 UTC (permalink / raw)
  To: git

Signed-off-by: Toby Allsopp <toby.allsopp@navman•co.nz>
---
 contrib/fast-import/git-p4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index c17afae..781a0cb 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1646,7 +1646,7 @@ class P4Clone(P4Sync):
         depotPath = args[0]
         depotDir = re.sub("(@[^@]*)$", "", depotPath)
         depotDir = re.sub("(#[^#]*)$", "", depotDir)
-	depotDir = re.sub(r"\.\.\.$", "", depotDir)
+        depotDir = re.sub(r"\.\.\.$", "", depotDir)
         depotDir = re.sub(r"/$", "", depotDir)
         return os.path.split(depotDir)[1]
 
-- 
1.5.4.7.gd8534-dirty

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] git-p4: Fix indentation from tab to spaces
  2008-02-04 20:41 [PATCH] git-p4: Fix indentation from tab to spaces Toby Allsopp
@ 2008-02-04 22:18 ` Tommy Thorn
  0 siblings, 0 replies; 2+ messages in thread
From: Tommy Thorn @ 2008-02-04 22:18 UTC (permalink / raw)
  To: Toby Allsopp; +Cc: git

Toby Allsopp wrote:
> Signed-off-by: Toby Allsopp <toby.allsopp@navman•co.nz>
> ---
>  contrib/fast-import/git-p4 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
> index c17afae..781a0cb 100755
> --- a/contrib/fast-import/git-p4
> +++ b/contrib/fast-import/git-p4
> @@ -1646,7 +1646,7 @@ class P4Clone(P4Sync):
>          depotPath = args[0]
>          depotDir = re.sub("(@[^@]*)$", "", depotPath)
>          depotDir = re.sub("(#[^#]*)$", "", depotDir)
> -	depotDir = re.sub(r"\.\.\.$", "", depotDir)
> +        depotDir = re.sub(r"\.\.\.$", "", depotDir)
>          depotDir = re.sub(r"/$", "", depotDir)
>          return os.path.split(depotDir)[1]
>  
>   
Acked-by: Tommy Thorn <tommy-git@thorn•ws>

I'm not sure that happend, but I did have some issues sending the patch 
that should be fixed now.

Nobody commented on the most important one - the fix for git-p4 memory 
appetite.

Tommy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-04 22:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-04 20:41 [PATCH] git-p4: Fix indentation from tab to spaces Toby Allsopp
2008-02-04 22:18 ` Tommy Thorn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox