public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: "René Scharfe" <rene.scharfe@lsrfire•ath.cx>
To: Lea Wiemann <lewiemann@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
	Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH 0/6] archive: refactor and cleanup
Date: Tue, 15 Jul 2008 09:49:35 +0200	[thread overview]
Message-ID: <487C568F.6030705@lsrfire.ath.cx> (raw)
In-Reply-To: <487BE440.9010006@gmail.com>

Lea Wiemann schrieb:
> René Scharfe wrote:
>> This series is a collection of cleanups for git archive
> 
> A few things:
> 
> * The note quoted above probably shouldn't be in the commit message but
> after the "---".

Since it's in the zeroth message, it's not intended to be committed.

> * You patch messages seem to be In-Reply-To a message that wasn't posted
> on the list, not to PATCH 0/6.

Hmm, that's strange.  Won't happen next time, though.

> * Unless you have a specific reason, I suggest that you don't Cc Junio
> on patches; he reads all messages on this list (more or less) and will
> usually simply apply your patches once they're reviewed.  (Watch for his
> periodical "What's cooking in git.git" messages to see if he got them.)

We're both wrong, quoth Documentation/SubmittingPatches:

    Note that your maintainer does not necessarily read everything
    on the git mailing list.  If your patch is for discussion first,
    send it "To:" the mailing list, and optionally "cc:" him.  If it
    is trivially correct or after the list reached a consensus, send
    it "To:" the maintainer and optionally "cc:" the list.

Obviously, my patches weren't trivially correct nor a consensus reached.

> * And most importantly, your Thunderbird introduced line-breaks, so it's
> not possible to apply the patches.  May I suggest you use git-send-email
> instead?

Well, it is possible to send usable patches with Thunderbird, using the
extension Toggle Word Wrap.  Patches 1 and 3 are damaged because I
edited them again to correct a typo -- with word wrap accidentally on.

Trying git-send-email again is a good idea, though.

> Feel free to ping me on IRC (lea_w in #git) if you need help.

I've slacked long enough to become a complete noob again.  Oh, well.

Thanks,
René

next prev parent reply	other threads:[~2008-07-15  7:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14 19:21 [PATCH 0/6] archive: refactor and cleanup René Scharfe
2008-07-14 23:41 ` Lea Wiemann
2008-07-15  0:27   ` Lea Wiemann
2008-07-15  7:49   ` René Scharfe [this message]
2008-07-15 15:21     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487C568F.6030705@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire$(echo .)ath.cx \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=lewiemann@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox