From: Johannes Sixt <j.sixt@viscovery•net>
To: Gustaf Hendeby <hendeby@isy•liu.se>
Cc: git@vger•kernel.org, spearce@spearce•org
Subject: Re: [PATCH] git-gui: Help identify aspell version on Windows too
Date: Fri, 26 Sep 2008 08:29:48 +0200 [thread overview]
Message-ID: <48DC815C.6030401@viscovery.net> (raw)
In-Reply-To: <1222378282-21757-1-git-send-email-hendeby@isy.liu.se>
Gustaf Hendeby schrieb:
> On windows, git gui fails to correctly extract the aspell version
> (experienced with aspell version 0.50.3) due to scilent white space at
> the end of the version string. Trim the obtained version string to
> work around this.
With this I've partial success here: Aspell 0.50.3 alpha (downloaded from
http://aspell.net/win32/) is recognized, but
- it only ever checks the first line of the commit message;
- after I change the catalog in the Options, I can't "Save" (it does
nothing), until I change to some other catalog. I haven't discovered the
pattern, yet, when the "Save" succeeds.
- At startup the correct catalog is used. But if I change the catalog
during a session (if I succeed, see above), then the second-last picked
catalog is used.
Any idea how to debug this?
> @@ -80,7 +80,7 @@ method _connect {pipe_fd} {
> error_popup [strcat [mc "Unrecognized spell checker"] ":\n\n$s_version"]
> return
> }
> - set s_version [string range $s_version 5 end]
> + set s_version [string range [string trim $s_version] 5 end]
A strange indentation you have here.
> regexp \
> {International Ispell Version .* \(but really (Aspell .*?)\)$} \
> $s_version _junk s_version
-- Hannes
next prev parent reply other threads:[~2008-09-26 6:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 21:31 [PATCH] git-gui: Help identify aspell version on Windows too Gustaf Hendeby
2008-09-26 6:29 ` Johannes Sixt [this message]
2008-09-26 9:05 ` Gustaf Hendeby
2008-09-26 9:31 ` Johannes Sixt
2008-09-26 14:31 ` Shawn O. Pearce
2008-09-26 15:06 ` Johannes Sixt
2008-09-26 14:28 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DC815C.6030401@viscovery.net \
--to=j.sixt@viscovery$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=hendeby@isy$(echo .)liu.se \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox