From: Jens Lehmann <Jens.Lehmann@web•de>
To: Lars Hjemli <hjemli@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH] git submodule summary: add --files option
Date: Sat, 15 Aug 2009 13:40:55 +0200 [thread overview]
Message-ID: <4A869EC7.7080701@web.de> (raw)
In-Reply-To: <8c5c35580908150140q1d209664ic5e3816609365e24@mail.gmail.com>
Lars Hjemli schrieb:
> On Fri, Aug 14, 2009 at 21:52, Junio C Hamano<gitster@pobox•com> wrote:
>> Jens Lehmann <Jens.Lehmann@web•de> writes:
>>
>>> git submodule summary is providing similar functionality for submodules as
>>> git diff-index does for a git project (including the meaning of --cached).
>>> But the analogon to git diff-files is missing, so add a --files option to
>>> summarize the differences between the index of the super project and the
>>> last commit checked out in the working tree of the submodule.
>>>
>>> Signed-off-by: Jens Lehmann <Jens.Lehmann@web•de>
>> Makes sense to me. Comments?
>
> Acked-by: Lars Hjemli <hjemli@gmail•com> with a tiny fixup:
>
> --- a/Documentation/git-submodule.txt
> +++ b/Documentation/git-submodule.txt
> @@ -129,7 +129,7 @@ summary::
> in the submodule between the given super project commit and the
> index or working tree (switched by --cached) are shown. If the option
> --files is given, show the series of commits in the submodule between
> - the index of super project the and the working tree of the submodule
> + the index of the super project and the working tree of the submodule
> (this option doesn't allow to use the --cached option or to provide an
> explicit commit).
Yup, sentence this makes much more sense now ... :-)
Shall i send an updated patch?
Jens
prev parent reply other threads:[~2009-08-15 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 19:32 [PATCH] git submodule summary: add --files option Jens Lehmann
2009-08-14 19:52 ` Junio C Hamano
2009-08-15 8:40 ` Lars Hjemli
2009-08-15 11:40 ` Jens Lehmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A869EC7.7080701@web.de \
--to=jens.lehmann@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=hjemli@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox