From: Karl Wiberg <kha@treskal•com>
To: Alex Chiang <achiang@hp•com>
Cc: catalin.marinas@gmail•com, git@vger•kernel.org
Subject: Re: [PATCH 1/6] stg mail: Refactor __send_message and friends
Date: Sun, 29 Nov 2009 10:13:44 +0100 [thread overview]
Message-ID: <4B123B48.4050405@treskal.com> (raw)
In-Reply-To: <20091128195016.949.17089.stgit@bob.kio>
Alex Chiang wrote:
> Instead of passing all the various smtp* args to __send_message
> individually, let's just pass the options list instead.
Looks good.
> + if (smtppassword and not smtpuser):
> + raise CmdException, 'SMTP password supplied, username needed'
> + if (smtpusetls and not smtpuser):
> + raise CmdException, 'SMTP over TLS requested, username needed'
Python style nit: Use "raise Exception('message')" in new code. (And
yes, I know you just moved these lines around.)
--
Karl Wiberg, kha@treskal•com
subrabbit.wordpress.com
www.treskal.com/kalle
next prev parent reply other threads:[~2009-11-29 9:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 19:50 [StGit RFC PATCH 0/6] add support for git send-email Alex Chiang
2009-11-28 19:50 ` [PATCH 1/6] stg mail: Refactor __send_message and friends Alex Chiang
2009-11-29 9:13 ` Karl Wiberg [this message]
2009-11-30 23:58 ` Alex Chiang
2009-11-28 19:50 ` [PATCH 2/6] stg mail: reorder __build_[message|cover] parameters Alex Chiang
2009-11-28 19:50 ` [PATCH 3/6] stg mail: make __send_message do more Alex Chiang
2009-11-29 21:23 ` Karl Wiberg
2009-11-30 23:59 ` Alex Chiang
2009-12-01 7:26 ` Karl Wiberg
2009-11-28 19:50 ` [PATCH 4/6] stg mail: factor out __update_header Alex Chiang
2009-11-28 19:50 ` [PATCH 5/6] stg mail: add basic support for git send-email Alex Chiang
2009-11-29 21:54 ` Karl Wiberg
2009-12-01 0:00 ` Alex Chiang
2009-12-01 7:33 ` Karl Wiberg
2009-11-28 19:50 ` [PATCH 6/6] stg mail: don't parse To/Cc/Bcc in --git mode Alex Chiang
2009-11-29 22:05 ` [StGit RFC PATCH 0/6] add support for git send-email Karl Wiberg
2009-12-01 0:02 ` Alex Chiang
2009-12-01 7:38 ` Karl Wiberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B123B48.4050405@treskal.com \
--to=kha@treskal$(echo .)com \
--cc=achiang@hp$(echo .)com \
--cc=catalin.marinas@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox