From: Johannes Sixt <j6t@kdbg•org>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: What's cooking in git.git (Jan 2010, #01; Mon, 04)
Date: Tue, 05 Jan 2010 21:49:14 +0100 [thread overview]
Message-ID: <4B43A5CA.7090104@kdbg.org> (raw)
In-Reply-To: <7vhbr1bagk.fsf@alter.siamese.dyndns.org>
Junio C Hamano schrieb:
> While you are technically correct that the change you made in t4030 is not
> justified by the commit log message in the sense that the "hexdump" script
> will go through run_command() interface and is not subject to the special
> rules filter writers need to keep in mind, the patch text itself is a good
> change, isn't it?
The patch text is good, but since it will not make a difference (and there
are a ton of other places that use /bin/sh successfully), the change is
not warrented at this time, IMO.
> As "run-command: convert simple callsites to use_shell" is the one that
> changes the filter_buffer(), do you want to have t0021 patch before that
> one, to prepare the test for the coming change?
Well, the test will break on Windows only after "run-command: optimize out
useless shell calls", and I wrote the commit message accordingly. If you
move it before that one (and if you are picky) the commit message should
be changed as well.
-- Hannes
next prev parent reply other threads:[~2010-01-05 21:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 8:39 What's cooking in git.git (Jan 2010, #01; Mon, 04) Junio C Hamano
2010-01-04 16:19 ` Matthieu Moy
2010-01-04 19:10 ` Junio C Hamano
2010-01-04 16:29 ` Johannes Sixt
2010-01-05 1:35 ` Junio C Hamano
2010-01-05 4:20 ` Jeff King
2010-01-05 5:18 ` Junio C Hamano
2010-01-05 20:49 ` Johannes Sixt [this message]
2010-01-06 7:47 ` Junio C Hamano
2010-01-06 9:08 ` Johannes Sixt
2010-01-06 17:04 ` Junio C Hamano
2010-01-05 5:57 ` Junio C Hamano
2010-01-05 6:40 ` Jeff King
2010-01-05 7:28 ` Tay Ray Chuan
2010-01-05 8:16 ` [PATCH] Teach --[no-]rerere-autoupdate option to merge, revert and friends Junio C Hamano
2010-01-05 11:31 ` What's cooking in git.git (Jan 2010, #01; Mon, 04) Johan Herland
2010-01-05 11:56 ` Ilari Liusvaara
2010-01-06 1:04 ` Junio C Hamano
2010-01-06 10:18 ` Nanako Shiraishi
2010-01-06 11:29 ` Johannes Schindelin
2010-01-06 17:07 ` Junio C Hamano
2010-01-07 11:05 ` [PATCH (v2) 1/2] rebase: fix --onto A...B parsing and add tests Nanako Shiraishi
2010-01-07 11:05 ` [PATCH (v2) 2/2] rebase -i: teach --onto A...B syntax Nanako Shiraishi
2010-01-07 20:19 ` Junio C Hamano
2010-01-07 21:10 ` Johannes Sixt
2010-01-08 20:16 ` Avery Pennarun
2010-01-08 20:22 ` Sverre Rabbelier
2010-01-08 20:31 ` Avery Pennarun
2010-01-08 20:37 ` Sverre Rabbelier
2010-01-08 23:21 ` A Large Angry SCM
2010-01-09 1:36 ` Johannes Schindelin
2010-01-09 21:02 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B43A5CA.7090104@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox