From: Michael J Gruber <git@drmicha•warpmail.net>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org, Eli Barzilay <eli@barzilay•org>
Subject: Re: [PATCH] rev-list: heed --abbrev-commit option
Date: Sat, 27 Mar 2010 14:30:28 +0100 [thread overview]
Message-ID: <4BAE0874.6090603@drmicha.warpmail.net> (raw)
In-Reply-To: <7vk4sylvzj.fsf@alter.siamese.dyndns.org>
Junio C Hamano venit, vidit, dixit 26.03.2010 20:32:
> Michael J Gruber <git@drmicha•warpmail.net> writes:
>
>> Currently, rev-list has a default of "0" for abbrev which means that
>> switching on abbreviations with --abbrev-commit has no visible effect,
>> even though the option is documented.
>
> Hmm, I actually think this was deliberate. rev-list is designed to be a
> low level machinery for getting full object names, and in that context,
> setting the default abbreviation length to "don't abbreviate" gave us some
> safety, with additional safety of requiring a separate --abbrev-commit
> option to affect the main "show the commit object names" codepath (the
> latter of which would not likely to change). The caller sets explicitly
> how long an output it wants (see git-rebase--interactive for an example).
My thinking was that unless --abbrev-commit is specified, nothing is
abbreviated, so that one has reproducible (plumbing) behaviour.
I learned that --abbrev= implies --abbrev-commit, but again, this means
explicitly requiring non-plumbing behavior.
>
> Having said that, I don't think this would break existing scripts, so
> let's queue it and see what happens.
OK!
Michael
next prev parent reply other threads:[~2010-03-27 13:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 11:30 git rev-list formatting Eli Barzilay
2010-03-22 11:39 ` Eli Barzilay
2010-03-22 13:08 ` Michael J Gruber
2010-03-22 13:36 ` [PATCH] rev-list: heed --abbrev-commit option Michael J Gruber
2010-03-26 19:32 ` Junio C Hamano
2010-03-27 13:30 ` Michael J Gruber [this message]
2010-03-22 14:42 ` git rev-list formatting Eli Barzilay
2010-03-22 17:22 ` René Scharfe
2010-03-23 1:57 ` Eli Barzilay
2010-03-23 10:52 ` Michael J Gruber
2010-03-23 11:06 ` Eli Barzilay
2010-03-23 12:26 ` Jeff King
2010-03-23 12:40 ` Erik Faye-Lund
2010-03-23 12:59 ` Eli Barzilay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAE0874.6090603@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=eli@barzilay$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox