From: Eric Blake <eblake@redhat•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org, jon.seymour@gmail•com
Subject: Re: [PATCH] Makefile: update defaults for modern Cygwin
Date: Mon, 05 Apr 2010 07:14:54 -0600 [thread overview]
Message-ID: <4BB9E24E.4090206@redhat.com> (raw)
In-Reply-To: <20100403074700.GA24176@progeny.tock>
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
On 04/03/2010 01:47 AM, Jonathan Nieder wrote:
> Red Hat internal people might want to be able to use 1.8 when it comes
> out. Maybe something like this would do the trick? I don’t know whether
> Cygwin 1.6 has the fixes 1.7 does, so in my ignorance I lumped it with
> 1.5.
Cygwin 1.6 is on par with 1.5 feature-wise, so your cutoff of 1.6 as the
last old version is correct.
> @@ -831,7 +831,7 @@ ifeq ($(uname_S),SunOS)
> BASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__ -DHAVE_ALLOCA_H
> endif
> ifeq ($(uname_O),Cygwin)
> - ifneq ($(wordlist 1, 2, $(subst ., ,$(uname_R))),1 7)
> + ifeq ($(shell expr "$(uname_R)" : '1\.[1-6]\.'),4)
It would be nice to use fewer processes, since forking is so expensive
on cygwin:
ifeq ($(shell case '$(uname_R)' in 1.[1-6].*) echo old;; esac),old)
But does that work to have unbalanced ) in a makefile $(shell)? On the
other hand, this is already in a chunk guarded by $(uname_S) being
cygwin, and we know that cygwin shells understand:
ifeq ($(shell case '$(uname_R)' in (1.[1-6].*) echo old;; esac),old)
even though it is not portable to other shells, like Solaris /bin/sh.
--
Eric Blake eblake@redhat•com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 323 bytes --]
next prev parent reply other threads:[~2010-04-05 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 22:43 [PATCH] Makefile: update defaults for modern Cygwin Eric Blake
2010-04-02 6:47 ` Junio C Hamano
2010-04-02 14:03 ` Eric Blake
2010-04-03 7:47 ` Jonathan Nieder
2010-04-03 18:28 ` Junio C Hamano
2010-04-03 19:52 ` [PATCH] Teach mailinfo %< as an alternative scissors mark Jonathan Nieder
2010-04-05 13:14 ` Eric Blake [this message]
2010-04-05 14:30 ` [PATCH] Makefile: update defaults for modern Cygwin Jonathan Nieder
2010-04-05 14:44 ` Eric Blake
2010-04-05 15:11 ` [PATCH] Makefile: avoid a fork in Cygwin version check Jonathan Nieder
2010-04-05 15:36 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB9E24E.4090206@redhat.com \
--to=eblake@redhat$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jon.seymour@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox