From: Andreas Schwab <schwab@linux-m68k•org>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Eric Blake <eblake@redhat•com>,
Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org, jon.seymour@gmail•com
Subject: Re: [PATCH] Makefile: avoid a fork in Cygwin version check
Date: Mon, 05 Apr 2010 17:36:48 +0200 [thread overview]
Message-ID: <m2eiitc3n3.fsf@igel.home> (raw)
In-Reply-To: <20100405151059.GB13761@progeny.tock> (Jonathan Nieder's message of "Mon, 5 Apr 2010 10:11:00 -0500")
Jonathan Nieder <jrnieder@gmail•com> writes:
> diff --git a/Makefile b/Makefile
> index e210a42..767fb66 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -831,7 +831,7 @@ ifeq ($(uname_S),SunOS)
> BASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__ -DHAVE_ALLOCA_H
> endif
> ifeq ($(uname_O),Cygwin)
> - ifeq ($(shell expr "$(uname_R)" : '1\.[1-6]\.'),4)
> + ifeq ($(shell case '$(uname_R)' in (1.[1-6].*) echo old;; esac),old)
Even less forks:
ifneq ($(filter 1.1.% 1.2.% 1.3.% 1.4.% 1.5.% 1.6.%,$(uname_R)),)
Andreas.
--
Andreas Schwab, schwab@linux-m68k•org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2010-04-05 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 22:43 [PATCH] Makefile: update defaults for modern Cygwin Eric Blake
2010-04-02 6:47 ` Junio C Hamano
2010-04-02 14:03 ` Eric Blake
2010-04-03 7:47 ` Jonathan Nieder
2010-04-03 18:28 ` Junio C Hamano
2010-04-03 19:52 ` [PATCH] Teach mailinfo %< as an alternative scissors mark Jonathan Nieder
2010-04-05 13:14 ` [PATCH] Makefile: update defaults for modern Cygwin Eric Blake
2010-04-05 14:30 ` Jonathan Nieder
2010-04-05 14:44 ` Eric Blake
2010-04-05 15:11 ` [PATCH] Makefile: avoid a fork in Cygwin version check Jonathan Nieder
2010-04-05 15:36 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eiitc3n3.fsf@igel.home \
--to=schwab@linux-m68k$(echo .)org \
--cc=eblake@redhat$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jon.seymour@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox