public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Michael J Gruber <git@drmicha•warpmail.net>
To: Tay Ray Chuan <rctay89@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>,
	Jeff King <peff@peff•net>
Subject: Re: [PATCH 2/2] wt-status: take advice.statusHints seriously
Date: Fri, 23 Apr 2010 10:09:52 +0200	[thread overview]
Message-ID: <4BD155D0.5080402@drmicha.warpmail.net> (raw)
In-Reply-To: <q2ibe6fef0d1004222115gcdd8fd81xce8993508bfa9f5d@mail.gmail.com>

Tay Ray Chuan venit, vidit, dixit 23.04.2010 06:15:
> Hi,
> 
> On Fri, Apr 23, 2010 at 4:30 AM, Michael J Gruber
> <git@drmicha•warpmail.net> wrote:
>>                else if (s->untracked.nr)
>> -                       printf("nothing added to commit but untracked files present (use \"git add\" to track)\n");
>> +                       printf("nothing added to commit but untracked files present%s\n",
>> +                               advice_status_hints
>> +                               ? " (use \"git add\" to track)" : "");
> 
> while we're at it, perhaps we could put the hints on its own line,

I don't think I'm the only one to turn sour at every encounter with the
phrase "while we're at it". I did fix one extraneous space in code
"while I was at it", yes, but:

> with a "hint: " prefix:
> 
>   nothing added to commit but untracked files present
>   hint: use "git add" to track
> 
> This way, we give future git usability hackers the space to elaborate
> further on why a certain flag or command was recommended.
> 

I'm suggesting a change in (output) behaviour (hint vs. no hint), which
one may even consider to be a bug fix in terms of matching the obvious
expections related to advice.statusHints false.

You're suggesting a different presentation of the output. In fact, I
noticed inconsistent capitalisation in the hints which should be
adjusted, maybe together with the presentation.

But I deem both changes (overlapping though) unrelated.

Cheers,
Michael

next prev parent reply	other threads:[~2010-04-23  8:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 14:47 [RFC/RFD] wt-status: take advice.statusHints seriously Michael J Gruber
2010-04-22  7:48 ` Junio C Hamano
2010-04-22 20:30   ` [PATCH 1/2] t7508: test advice.statusHints Michael J Gruber
2010-04-22 20:30     ` [PATCH 2/2] wt-status: take advice.statusHints seriously Michael J Gruber
2010-04-23  4:15       ` Tay Ray Chuan
2010-04-23  8:09         ` Michael J Gruber [this message]
2010-04-23 18:31           ` Jakub Narebski
2010-04-26 19:10           ` Jeff King
2010-04-26 19:10       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD155D0.5080402@drmicha.warpmail.net \
    --to=git@drmicha$(echo .)warpmail.net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=peff@peff$(echo .)net \
    --cc=rctay89@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox