From: Michael J Gruber <git@drmicha•warpmail.net>
To: unlisted-recipients:; (no To-header on input)
Cc: "Gary V. Vaughan" <git@mlists•thewrittenword.com>, git@vger•kernel.org
Subject: Re: [patch 00/16] Portability Patches for git-1.7.1 (v4)
Date: Sat, 01 May 2010 20:34:54 +0200 [thread overview]
Message-ID: <4BDC744E.4050006@drmicha.warpmail.net> (raw)
In-Reply-To: <4BD7032D.9050508@drmicha.warpmail.net>
[resent after vger recovery]
Michael J Gruber venit, vidit, dixit 27.04.2010 17:30:
> Gary V. Vaughan venit, vidit, dixit 27.04.2010 15:57:
>> Here are the portability patches we needed at TWW to enable git-1.7.1
>> to compile and run on all of the wide range of Unix machines we
>> support. These patches apply to the git-1.7.1 release, and address
>> all of the feedback from the previous three times I posted them to
>> this list, including fixing the massive testsuite failures I was
>> experiencing and taking into account that the ss_family fixes and
>> partial GMT_CMP_TEST fixes that have been pushed since my last post of
>> this patch queue.
>
> General remark: None of your patches have a s-o-b line. If you want to
> have your patches in git you are required to sign-off on them (commit
> -s) in order to certify that you can submit them under the license terms
> of the project.
>
> Your diff -> test_cmp are certainly something we want to have in any
> case. The code changes look ugly, honestly, making the code much less
> readable, but it seems to be the only way to make those older platforms
> and compilers happy. (Erik pointed out some good ways to reduce the
> uglyness somewhat.)
>
> I can't test your target platform, but I would test the impact of the
> code and test changes on mine. Do you have your series somewhere to pull
> from?
OK, unsurprsingly, tests still pass on Linux (Fedora 12 x86_64).
If anyone wants to try, the series can be found at
git://repo.or.cz/git/mjg.git
in branch
gvv/platform-compatibility
applied cleanly on current master.
Cheers,
Michael
next prev parent reply other threads:[~2010-05-01 18:35 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 13:57 [patch 00/16] Portability Patches for git-1.7.1 (v4) Gary V. Vaughan
2010-04-27 13:57 ` [patch 01/16] user-cppflags.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 02/16] const-expr.patch Gary V. Vaughan
2010-04-27 14:08 ` Erik Faye-Lund
2010-04-27 14:32 ` Gary V. Vaughan
[not found] ` <1AFA5FB2-EB8B-4775-8941-86428C7F740E@gmail.com>
2010-05-03 1:39 ` Gary V. Vaughan
[not found] ` <A4E8B513-AD31-4F3B-9DEF-6A85AA8DC7B3@gmail.com>
2010-05-04 5:01 ` Gary V. Vaughan
2010-04-27 13:57 ` [patch 03/16] pthread.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 04/16] Without this patch at least IBM VisualAge C 5.0 (I have 5.0.2) on AIX 5.1 fails to compile git Gary V. Vaughan
2010-04-27 16:08 ` Tor Arntsen
2010-04-28 8:40 ` Gary V. Vaughan
2010-04-28 8:55 ` Tor Arntsen
2010-04-28 16:23 ` Jeff King
2010-04-27 13:57 ` [patch 05/16] diff-export.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 06/16] diff-test_cmp.patch Gary V. Vaughan
2010-04-27 17:15 ` Jonathan Nieder
2010-04-28 9:00 ` Gary V. Vaughan
2010-04-28 9:51 ` Jonathan Nieder
2010-04-28 10:22 ` Gary V. Vaughan
2010-04-28 17:43 ` Jonathan Nieder
2010-04-27 13:57 ` [patch 07/16] diff-defaults.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 08/16] host-SunOS56.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 09/16] host-IRIX.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 10/16] host-HPUX10.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 11/16] host-HPUX11.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 12/16] host-OSF1.patch Gary V. Vaughan
2010-04-27 14:10 ` Tor Arntsen
2010-04-27 14:39 ` Gary V. Vaughan
2010-04-27 14:48 ` Tor Arntsen
2010-04-28 9:07 ` Gary V. Vaughan
2010-04-27 13:57 ` [patch 13/16] no-hstrerror.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 14/16] no-inet_ntop.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 15/16] no-socklen_t.patch Gary V. Vaughan
2010-04-27 13:57 ` [patch 16/16] no-inline.patch Gary V. Vaughan
2010-04-27 15:30 ` [patch 00/16] Portability Patches for git-1.7.1 (v4) Michael J Gruber
2010-04-27 17:54 ` Jeff King
2010-04-27 20:13 ` Andreas Schwab
2010-04-28 2:08 ` Jeff King
2010-04-28 9:19 ` Gary V. Vaughan
2010-04-28 12:17 ` Jeff King
2010-04-28 9:27 ` Gary V. Vaughan
2010-04-28 9:32 ` Gary V. Vaughan
2010-04-28 12:26 ` Ævar Arnfjörð Bjarmason
[not found] ` <4BD94599.5090309@drmicha.warpmail.net>
2010-04-29 10:50 ` Gary V. Vaughan
2010-05-01 18:34 ` Michael J Gruber [this message]
2010-05-01 23:25 ` Junio C Hamano
2010-05-03 1:48 ` Gary V. Vaughan
2010-05-02 13:00 ` Øyvind A. Holm
2010-04-28 10:12 ` Gary V. Vaughan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDC744E.4050006@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@mlists$(echo .)thewrittenword.com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox