From: Johannes Sixt <j6t@kdbg•org>
To: Jeff King <peff@peff•net>
Cc: Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org, Brandon Casey <drafnel@gmail•com>
Subject: Re: [PATCH] attr: map builtin userdiff drivers to well-known extensions
Date: Fri, 16 Dec 2011 23:05:27 +0100 [thread overview]
Message-ID: <4EEBC0A7.3030303@kdbg.org> (raw)
In-Reply-To: <20111216192104.GA19924@sigill.intra.peff.net>
Am 16.12.2011 20:21, schrieb Jeff King:
> I'm not clear from what you wrote on whether you were saying it is
> simply sub-optimal, or whether on balance it is way worse than the
> default funcname matching.
I'm saying the latter. Okay, we're talking "only" about hunk headers.
But when you are reviewing patches, they are *extremely* useful and a
time-saver; when they are wrong or not present, they are exactly the
opposite.
> So, I'm confused. If you are using this, surely you have "*.c diff=xcpp"
> in your attributes file, and my patch has no effect for you,
Sure I have. What I didn't say (sorry for that!), but wanted to hint at
is that this is to experiment with a pattern in order to ultimately
improve the built-in pattern. The topic came up just the other day, and
I took Thomas Rast's suggestion to experiment with a simplified pattern:
http://thread.gmane.org/gmane.comp.version-control.git/186355/focus=186439
But as is, the built-in pattern misses way too many anchor points in C++
code.
-- Hannes
next prev parent reply other threads:[~2011-12-16 22:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 11:00 [PATCH] attr: map builtin userdiff drivers to well-known extensions Jeff King
2011-12-16 14:00 ` Johannes Sixt
2011-12-16 17:01 ` Junio C Hamano
2011-12-16 19:21 ` Jeff King
2011-12-16 19:30 ` Jeff King
2011-12-16 19:33 ` Junio C Hamano
2011-12-17 1:17 ` Jeff King
2011-12-16 22:05 ` Johannes Sixt [this message]
2011-12-17 1:21 ` Jeff King
2011-12-17 3:38 ` Jonathan Nieder
2011-12-19 15:49 ` [PATCHv2 1/2] " Jeff King
2011-12-19 18:07 ` Jonathan Nieder
2011-12-19 18:55 ` Jeff King
2011-12-22 1:47 ` Ævar Arnfjörð Bjarmason
2011-12-19 15:57 ` [PATCHv2 2/2] attr: drop C/C++ default extension mapping Jeff King
2011-12-19 18:10 ` Jonathan Nieder
2011-12-19 20:51 ` Thomas Rast
2011-12-19 20:52 ` [PATCH] t4018: introduce test cases for the internal hunk header patterns Brandon Casey
2011-12-19 21:53 ` [PATCH] t4018: add a few more test cases for cpp hunk header matching Brandon Casey
2011-12-19 22:37 ` [PATCH] t4018: introduce test cases for the internal hunk header patterns Junio C Hamano
2011-12-19 22:57 ` Brandon Casey
2011-12-19 23:17 ` Junio C Hamano
2011-12-20 2:42 ` [PATCH v2] " Brandon Casey
2011-12-20 8:25 ` Jakub Narebski
2011-12-20 15:58 ` Brandon Casey
2011-12-20 9:13 ` Thomas Rast
2011-12-20 19:52 ` Johannes Sixt
2011-12-20 20:08 ` [PATCH] " Junio C Hamano
2011-12-16 17:51 ` [PATCH] attr: map builtin userdiff drivers to well-known extensions Mark Levedahl
2011-12-16 19:28 ` Jeff King
2011-12-16 19:26 ` Philip Oakley
2011-12-16 19:32 ` Jeff King
2011-12-22 0:05 ` Philip Oakley
2011-12-23 5:47 ` Jeff King
2011-12-16 19:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEBC0A7.3030303@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=drafnel@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox