public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: 김남형 <namhyung.kim@lge•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 1/3] help: Fix help message for aliases
Date: Thu, 15 Mar 2012 14:48:49 +0900	[thread overview]
Message-ID: <4F6182C1.9080600@lge.com> (raw)
In-Reply-To: <7vipi6mo93.fsf@alter.siamese.dyndns.org>

Hi,

2012-03-15 2:23 PM, Junio C Hamano wrote:
> Namhyung Kim <namhyung.kim@lge•com> writes:
>
>> -		printf("`git %s' is aliased to `%s'\n", argv[0], alias);
>> +		printf("`git %s' is aliased to `git %s'\n", argv[0], alias);
>
> NAK.
>
> What would the above change will do to one of my favorite alias?
>
> $ git help who
> `git who' is aliased to `!sh -c 'git log -1 --format="%an<%ae>" --author="$1"' -'
>
> Wouldn't removing "git " from the first phrase be a better solution?
>

Right. But as I replied to Jeff King, it can be improved to check whether the 
aliased output is such a complicated commands or not. Now I see that we can 
examine if the first letter is '!'.

Thanks,
Namhyung

next prev parent reply	other threads:[~2012-03-15  5:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15  2:52 [PATCH 1/3] help: Fix help message for aliases Namhyung Kim
2012-03-15  2:52 ` [PATCH 2/3] help: Add '--follow-alias' option Namhyung Kim
2012-03-15  6:00   ` Junio C Hamano
2012-03-15  6:15     ` 김남형
2012-03-15  6:23       ` Junio C Hamano
2012-03-15  6:46         ` Namhyung Kim
2012-03-15  7:09           ` Junio C Hamano
2012-03-15  2:52 ` [PATCH 3/3] help: Add 'help.follow-alias' config item Namhyung Kim
2012-03-15  6:06   ` Junio C Hamano
2012-03-15  6:29     ` Namhyung Kim
2012-03-15  4:17 ` [PATCH 1/3] help: Fix help message for aliases Jeff King
2012-03-15  5:15   ` 김남형
2012-03-15 13:19     ` Jeff King
2012-03-15  5:23 ` Junio C Hamano
2012-03-15  5:48   ` 김남형 [this message]
2012-03-15  6:18     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6182C1.9080600@lge.com \
    --to=namhyung.kim@lge$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox