From: Junio C Hamano <gitster@pobox•com>
To: Namhyung Kim <namhyung.kim@lge•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 1/3] help: Fix help message for aliases
Date: Wed, 14 Mar 2012 22:23:04 -0700 [thread overview]
Message-ID: <7vipi6mo93.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1331779969-8641-1-git-send-email-namhyung.kim@lge.com
Namhyung Kim <namhyung.kim@lge•com> writes:
> - printf("`git %s' is aliased to `%s'\n", argv[0], alias);
> + printf("`git %s' is aliased to `git %s'\n", argv[0], alias);
NAK.
What would the above change will do to one of my favorite alias?
$ git help who
`git who' is aliased to `!sh -c 'git log -1 --format="%an <%ae>" --author="$1"' -'
Wouldn't removing "git " from the first phrase be a better solution?
next prev parent reply other threads:[~2012-03-15 5:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 2:52 [PATCH 1/3] help: Fix help message for aliases Namhyung Kim
2012-03-15 2:52 ` [PATCH 2/3] help: Add '--follow-alias' option Namhyung Kim
2012-03-15 6:00 ` Junio C Hamano
2012-03-15 6:15 ` 김남형
2012-03-15 6:23 ` Junio C Hamano
2012-03-15 6:46 ` Namhyung Kim
2012-03-15 7:09 ` Junio C Hamano
2012-03-15 2:52 ` [PATCH 3/3] help: Add 'help.follow-alias' config item Namhyung Kim
2012-03-15 6:06 ` Junio C Hamano
2012-03-15 6:29 ` Namhyung Kim
2012-03-15 4:17 ` [PATCH 1/3] help: Fix help message for aliases Jeff King
2012-03-15 5:15 ` 김남형
2012-03-15 13:19 ` Jeff King
2012-03-15 5:23 ` Junio C Hamano [this message]
2012-03-15 5:48 ` 김남형
2012-03-15 6:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vipi6mo93.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=namhyung.kim@lge$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox